1331743 - Create CrossProcessCpowHolder even if there is no message manager

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Andrew McCreight [:mccr8]]

As of bug 1330018, we use ~CrossProcessCpowHolder to ensure that CPOWs sent by the message manager are always unwrapped, to prevent leaks and other badness. We should do this even if there is no message manager.

Comment 1

[Andrew McCreight [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d6ef8e09c768380e6badd1bef3449a462e25dcd

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1331743 - Create CrossProcessCpowHolder even if there is no message manager.

Review commit: https://reviewboard.mozilla.org/r/105616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105616/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8828107 [details]
Bug 1331743 - Create CrossProcessCpowHolder even if there is no message manager.

https://reviewboard.mozilla.org/r/105616/#review107016

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8828107 [details]
Bug 1331743 - Create CrossProcessCpowHolder even if there is no message manager.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/105616/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ecfb17dd235
Create CrossProcessCpowHolder even if there is no message manager. r=smaug

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2ecfb17dd235

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Do we need to backport this?

Comment 8

[Andrew McCreight [:mccr8]]

Nah, I never really had any evidence that it did anything.