Create CrossProcessCpowHolder even if there is no message manager

RESOLVED FIXED in Firefox 54

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox-esr45 unaffected, firefox51 unaffected, firefox52 wontfix, firefox53 wontfix, firefox54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
As of bug 1330018, we use ~CrossProcessCpowHolder to ensure that CPOWs sent by the message manager are always unwrapped, to prevent leaks and other badness. We should do this even if there is no message manager.
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8828107 [details]
Bug 1331743 - Create CrossProcessCpowHolder even if there is no message manager.

https://reviewboard.mozilla.org/r/105616/#review107016
Attachment #8828107 - Flags: review?(bugs) → review+
Comment hidden (mozreview-request)

Comment 5

2 years ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ecfb17dd235
Create CrossProcessCpowHolder even if there is no message manager. r=smaug

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2ecfb17dd235
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Do we need to backport this?
Flags: needinfo?(continuation)
(Assignee)

Comment 8

2 years ago
Nah, I never really had any evidence that it did anything.
status-firefox51: --- → unaffected
status-firefox52: --- → wontfix
status-firefox53: --- → wontfix
status-firefox-esr45: --- → unaffected
Flags: needinfo?(continuation)
You need to log in before you can comment on or make changes to this bug.