Closed Bug 1331774 Opened 4 years ago Closed 4 years ago
DOM instance used in Inspector, breaks event system .
59 bytes, text/x-review-board-request
The inspector's events are broken for React components as it uses the Toolbox's ReactDOM instance. This confuses React's synthetic event dispatching system, so the patch needs to be applied to the inspector as well.
Comment on attachment 8827657 [details] Bug 1331774 - Apply ReactDOM patch to the inspector panel; https://reviewboard.mozilla.org/r/105274/#review106126 I am curious to know how the netmonitor did not get affected by this, but r+ for now.
Attachment #8827657 - Flags: review?(gl) → review+
https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/vendor/react-dom.js#144-164 this bit of code explicitly checks for situations like the netmonitor, where it's a XUl iframe with a xul containing window, so that already fixes the netmonitor.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/66363b305bc6 Apply ReactDOM patch to the inspector panel; r=gl
You need to log in before you can comment on or make changes to this bug.