1331774 - Toolbox ReactDOM instance used in Inspector, breaks event system.

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Greg Tatum [:gregtatum]]

The inspector's events are broken for React components as it uses the Toolbox's ReactDOM instance. This confuses React's synthetic event dispatching system, so the patch needs to be applied to the inspector as well.

Comment 1

[Greg Tatum [:gregtatum]]

Attachment: Bug 1331774 - Apply ReactDOM patch to the inspector panel;

Review commit: https://reviewboard.mozilla.org/r/105274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105274/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8827657 [details]
Bug 1331774 - Apply ReactDOM patch to the inspector panel;

https://reviewboard.mozilla.org/r/105274/#review106126

I am curious to know how the netmonitor did not get affected by this, but r+ for now.

Comment 3

[Greg Tatum [:gregtatum]]

https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/vendor/react-dom.js#144-164 this bit of code explicitly checks for situations like the netmonitor, where it's a XUl iframe with a xul containing window, so that already fixes the netmonitor.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66363b305bc6
Apply ReactDOM patch to the inspector panel; r=gl

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/66363b305bc6