1331828 - First boot causes crashes on Windows

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Sotaro Ikeda [:sotaro]]

When I build graphics branch locally, first boot causes crashes.

Comment 1

[Sotaro Ikeda [:sotaro]]

I saw another problem with latest source, e10s with multiple tabs caused tab crash.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

I was seeing at least one crash caused by the call to SetLayerObserverEpoch in TabChild.cpp getting called before the WebRenderBridge was properly initialized. I have patches pending that will fix that (some in bug 1331509, and one in bug 1326421). If there are other crashes that you're seeing that are different then we'll need to investigate those.

Comment 3

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #1)
> I saw another problem with latest source, e10s with multiple tabs caused tab
> crash.

It was caused by the call to SetLayerObserverEpoch. It seems same to comment 2.

The crash of comment 0 is happened in WebRenderBridgeParent::RecvDPGetSnapshot().

Comment 4

[Sotaro Ikeda [:sotaro]]

The crash was caused by the following assert failure in gleam.

pub fn read_pixels_into_buffer(x: GLint, y: GLint, width: GLsizei, height: GLsizei,
                               format: GLenum, pixel_type: GLenum, dst_buffer: &mut [u8]) {
    // Assumes that the user properly allocated the size for dst_buffer.
    assert!(calculate_length(width, height, format, pixel_type) == dst_buffer.len());

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Fix ffi inconsistency of wr_readback_into_buffer()

Comment 6

[Sotaro Ikeda [:sotaro]]

argument buffer_size of wr_readback_into_buffer() is usize, but it is uint32_t in webrender_ffi.h.

pub extern fn wr_readback_into_buffer(window: &mut WrWindowState, width: u32, height: u32,
                                      dst_buffer: *mut u8, buffer_size: usize) {

Comment 7

[Sotaro Ikeda [:sotaro]]

It is a regression of Bug 1319170.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/543c59f9d5df
Fix ffi inconsistency of wr_readback_into_buffer() r=gfx?