Closed Bug 1331850 Opened 3 years ago Closed 3 years ago

Swap ClosestSide and FarthestSide in StyleShapeRadius.

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(1 file)

For two reasons:
1) The order of ClosestSide and FarthestSide in StyleShapeRadius is different from nsCSSProps::kShapeRadiusKTable [1]. While debugging the parsing of ellipse() in bug 1326406, I took me a while to figure out that the index of the KTable was different from the enum values StyleShapeRadius.
2) For aesthetic, the order matches the what's in the spec. [2]

[1] http://searchfox.org/mozilla-central/rev/c477aa8bd99278962998adba1c5e4b15a02c42c7/layout/style/nsCSSProps.cpp#2312-2314
[2] https://drafts.csswg.org/css-shapes/#typedef-shape-radius
Comment on attachment 8827747 [details]
Bug 1331850 - Swap ClosestSide and FarthestSide in StyleShapeRadius.

https://reviewboard.mozilla.org/r/105354/#review106200
Attachment #8827747 - Flags: review?(cam) → review+
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfdaba2327c9
Swap ClosestSide and FarthestSide in StyleShapeRadius. r=heycam
https://hg.mozilla.org/mozilla-central/rev/dfdaba2327c9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.