Closed Bug 1331850 Opened 3 years ago Closed 3 years ago
Side and Farthest Side in Style Shape Radius .
59 bytes, text/x-review-board-request
For two reasons: 1) The order of ClosestSide and FarthestSide in StyleShapeRadius is different from nsCSSProps::kShapeRadiusKTable . While debugging the parsing of ellipse() in bug 1326406, I took me a while to figure out that the index of the KTable was different from the enum values StyleShapeRadius. 2) For aesthetic, the order matches the what's in the spec.   http://searchfox.org/mozilla-central/rev/c477aa8bd99278962998adba1c5e4b15a02c42c7/layout/style/nsCSSProps.cpp#2312-2314  https://drafts.csswg.org/css-shapes/#typedef-shape-radius
Comment on attachment 8827747 [details] Bug 1331850 - Swap ClosestSide and FarthestSide in StyleShapeRadius. https://reviewboard.mozilla.org/r/105354/#review106200
Attachment #8827747 - Flags: review?(cam) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/dfdaba2327c9 Swap ClosestSide and FarthestSide in StyleShapeRadius. r=heycam
You need to log in before you can comment on or make changes to this bug.