1331857 - Create a base class for CanvasRenderingContext2D

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Kevin Chen[:kechen] (UTC + 8)]

According to Bug 1318573 comment 21, we need a base class for CanvasRenderingContext2D and PaintRenderingContext2D.

I will extract the base class in this bug and do the following refactor work back in Bug 1318573 so that I won't block by rebasing the patches.

Comment 1

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Create class BasicRenderingContext2D_v1

Hello George,
Could you help me to review this ?

Comment 2

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Create class BasicRenderingContext2D_v2

Fix some tailing spaces and indents.

George,
Could you help me to review this ?
Thank you.

Comment 3

[George Wright (:gw280) (needinfo me!)]

From IRC:

03:12 <gw280> so at the moment it looks like all you're doing is renaming CanvasRenderingContext2D to BasicRenderingContext2D
03:13 <gw280> and CRC2D is just a null implementation of BRC2D
03:13 <gw280> this seems pointless to me
03:13 <gw280> can we figure out what common components can be put into BRC2D and what CRC2D-specific stuff can go in there?
03:13 <gw280> at the very least, I'd rather we made BRC2D a pure virtual class and CRC2D stays the same, but now implements BRC2D
03:14 <gw280> I'd rather avoid a situation where we're moving a lot of our code and moving code history between files for no real reason

Comment 4

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Create class BasicRenderingContext2D_v3

Hello George, can you help me to review it ?
Or do you think we should just land this patch back in Bug 1318573 ?
The purpose of filing this bug is to separate the function migrations part by part so that I don't have to wait every migrations get reviewed before I land it.

Comment 5

[Kevin Chen[:kechen] (UTC + 8)]

There are some errors on try server with this patch.
I will examine the patch and request the review again.

Comment 6

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Create class BasicRenderingContext2D_v4

Hello George,

I add virtual keyword to CRC2 to prevent some Werror and change the order of the inheritance to prevent nsISupport assertion.
Could you help me to review it again ?

Comment 7

[Kevin Chen[:kechen] (UTC + 8)]

Here is the try run, the error seems irrelevant to this modify.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=276917ab4bbb2c896ba385601993f31de762d2fb

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17414d851efb
Create class BasicRenderingContext2D. r=gwright

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/17414d851efb