Remove bug 1312242 workaround

RESOLVED FIXED in Firefox 52

Status

()

Core
Plug-ins
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jimm, Assigned: jimm)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox52 fixed, firefox53 fixed)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

a year ago
Pull the temporary fix that landed in bug 1312242 from aurora so it doesn't end up in beta/release 52, and disable async drawing by default on aurora as well.
(Assignee)

Updated

a year ago
Assignee: nobody → jmathies
(Assignee)

Comment 1

a year ago
Created attachment 8827944 [details] [diff] [review]
aurora 52 patch
(Assignee)

Updated

a year ago
Attachment #8827944 - Flags: review?(benjamin)
(Assignee)

Comment 2

a year ago
I'm going to rework this so that it removes the work around from nightly as well.
Summary: Remove bug 1312242 workaround from aurora → Remove bug 1312242 workaround
(Assignee)

Comment 3

a year ago
Comment on attachment 8827944 [details] [diff] [review]
aurora 52 patch

We'll still want this on aurora before the merge.
Attachment #8827944 - Attachment description: patch → aurora 52 patch
(Assignee)

Comment 4

a year ago
Created attachment 8828108 [details] [diff] [review]
nightly 53 patch

same patch rebased for nightly
Attachment #8828108 - Flags: review?(benjamin)
(Assignee)

Comment 5

a year ago
review ping, FYI we can't start testing async drawing until this is on nightly.

Comment 6

a year ago
Comment on attachment 8828108 [details] [diff] [review]
nightly 53 patch

r=me for the PluginModuleParent.cpp change.

I don't think we should change the settings to nightly-only at the same time, so please don't land the all.js change. Now that Flash is updated with fixes, don't we want to do an intensive QA pass and try to have this ride 52 to beta and release?
Attachment #8828108 - Flags: review?(benjamin) → review+

Comment 7

a year ago
Comment on attachment 8827944 [details] [diff] [review]
aurora 52 patch

similar half-r+
Attachment #8827944 - Flags: review?(benjamin) → review+
(Assignee)

Comment 8

a year ago
(In reply to Benjamin Smedberg [:bsmedberg] from comment #6)
> Comment on attachment 8828108 [details] [diff] [review]
> nightly 53 patch
> 
> r=me for the PluginModuleParent.cpp change.
> 
> I don't think we should change the settings to nightly-only at the same
> time, so please don't land the all.js change. Now that Flash is updated with
> fixes, don't we want to do an intensive QA pass and try to have this ride 52
> to beta and release?

will do, thanks!
(Assignee)

Comment 9

a year ago
(In reply to Benjamin Smedberg [:bsmedberg] from comment #6)
> don't we want to do an intensive QA pass and try to have this ride 52
> to beta and release?

yes, I need to schedule something with softvision. we're working on test plan now.
(Assignee)

Comment 10

a year ago
Created attachment 8828877 [details] [diff] [review]
nightly 53 patch
Attachment #8828108 - Attachment is obsolete: true
Attachment #8828877 - Flags: review+
(Assignee)

Comment 11

a year ago
Created attachment 8828879 [details] [diff] [review]
aurora 52 patch

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1312242
[User impact if declined]:
this needs to land, it's a backout of a work around we landed in firefox that adobe later fixed internally in flash.
[Is this code covered by automated tests?]:
no
[Has the fix been verified in Nightly?]:
yes
[Needs manual test from QE? If yes, steps to reproduce]: 
testing will be scheduled 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
no
[Why is the change risky/not risky?]:
well understood code
[String changes made/needed]:
na
Attachment #8828879 - Flags: review?(jmathies)
Attachment #8828879 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

a year ago
Attachment #8828879 - Flags: review?(jmathies) → review+
(Assignee)

Updated

a year ago
Attachment #8827944 - Attachment is obsolete: true
Comment on attachment 8828879 [details] [diff] [review]
aurora 52 patch

drop workaround for flash issue, aurora52+
Attachment #8828879 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 13

a year ago
Pushed by jmathies@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/33d8699d32d3
Remove plugin async drawing work around that landed in bug 1312242. r=bsmedberg
(Assignee)

Updated

a year ago
Flags: needinfo?(jmathies)
(Assignee)

Updated

a year ago
status-firefox52: --- → affected
status-firefox52: affected → fixed

Comment 15

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/33d8699d32d3
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.