Closed Bug 1331951 Opened 9 years ago Closed 9 years ago

Remove bug 1312242 workaround

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52 fixed, firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(2 files, 2 obsolete files)

nightly 53 patch
1.77 KB, patch
jimm
: review+
Details | Diff | Splinter Review
aurora 52 patch
1.77 KB, patch
jimm
: review+
jcristau
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Pull the temporary fix that landed in bug 1312242 from aurora so it doesn't end up in beta/release 52, and disable async drawing by default on aurora as well.
Assignee: nobody → jmathies
Attached patch aurora 52 patch (obsolete) — — Splinter Review
Attachment #8827944 - Flags: review?(benjamin)
I'm going to rework this so that it removes the work around from nightly as well.
Summary: Remove bug 1312242 workaround from aurora → Remove bug 1312242 workaround
Comment on attachment 8827944 [details] [diff] [review] aurora 52 patch We'll still want this on aurora before the merge.
Attachment #8827944 - Attachment description: patch → aurora 52 patch
Attached patch nightly 53 patch (obsolete) — — Splinter Review
same patch rebased for nightly
Attachment #8828108 - Flags: review?(benjamin)
review ping, FYI we can't start testing async drawing until this is on nightly.
Comment on attachment 8828108 [details] [diff] [review] nightly 53 patch r=me for the PluginModuleParent.cpp change. I don't think we should change the settings to nightly-only at the same time, so please don't land the all.js change. Now that Flash is updated with fixes, don't we want to do an intensive QA pass and try to have this ride 52 to beta and release?
Attachment #8828108 - Flags: review?(benjamin) → review+
Comment on attachment 8827944 [details] [diff] [review] aurora 52 patch similar half-r+
Attachment #8827944 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg [:bsmedberg] from comment #6) > Comment on attachment 8828108 [details] [diff] [review] > nightly 53 patch > > r=me for the PluginModuleParent.cpp change. > > I don't think we should change the settings to nightly-only at the same > time, so please don't land the all.js change. Now that Flash is updated with > fixes, don't we want to do an intensive QA pass and try to have this ride 52 > to beta and release? will do, thanks!
(In reply to Benjamin Smedberg [:bsmedberg] from comment #6) > don't we want to do an intensive QA pass and try to have this ride 52 > to beta and release? yes, I need to schedule something with softvision. we're working on test plan now.
Attached patch nightly 53 patch — — Splinter Review
Attachment #8828108 - Attachment is obsolete: true
Attachment #8828877 - Flags: review+
Attached patch aurora 52 patch — — Splinter Review
Approval Request Comment [Feature/Bug causing the regression]: bug 1312242 [User impact if declined]: this needs to land, it's a backout of a work around we landed in firefox that adobe later fixed internally in flash. [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: yes [Needs manual test from QE? If yes, steps to reproduce]: testing will be scheduled [List of other uplifts needed for the feature/fix]: [Is the change risky?]: no [Why is the change risky/not risky?]: well understood code [String changes made/needed]: na
Attachment #8828879 - Flags: review?(jmathies)
Attachment #8828879 - Flags: approval-mozilla-aurora?
Attachment #8828879 - Flags: review?(jmathies) → review+
Attachment #8827944 - Attachment is obsolete: true
Comment on attachment 8828879 [details] [diff] [review] aurora 52 patch drop workaround for flash issue, aurora52+
Attachment #8828879 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Pushed by jmathies@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/33d8699d32d3 Remove plugin async drawing work around that landed in bug 1312242. r=bsmedberg
Flags: needinfo?(jmathies)
status-firefox52: --- → affected
https://hg.mozilla.org/mozilla-central/rev/33d8699d32d3
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: