1331955 - Launching blank new tab from Today widget while app is on settings view causes Firefox to crash

Status: RESOLVED WORKSFORME

(Firefox for iOS :: Home screen, defect, P2)

Description

[Stephan Leroux [:sleroux]]

STR:

1. Launch Firefox
2. Navigate to Settings -> New Tab
3. Set new tab option to be 'Blank Page'
4. Navigate back to main settings page
5. Background Firefox
6. Open 'New Tab' from Today Widget

Expected:

Settings screen is dismissed and new tab is shown with URL bar focused

Actual:

Settings screen is dismissed and app crashes

----

Looks like we're crashing when a TopSiteItemCell is trying to set an image here [1]. My guess is that since this block is called async and the ActivityStreamPanel is probably gone at this point, self is nil and we're trying to reference it. Xcode shows that the exception is thrown by _swift_abortRetainUnowned.

[1] https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Frontend/Home/ActivityStreamTopSitesCell.swift#L133

Comment 1

[Adrian Oniga]

 I can not reproduce this on iPhone 6, iOS 10.2, Firefox version 7.0(1), buddybuild #1170

Comment 2

[Emily Toop (:fluffyemily)]

Unable to replicate on latest master. Closing. #c2a3b51