1331995 - [RTL] On some occasions, the URL on the URL bar disappears

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Itiel]

STR #1:
1. Install Nightly, Hebrew locale
2. Enter random webpages
3. Open a New Tab -> History
4. Click any of the items there
5. While Nightly loads the page, observe the URL bar

AR for STR #1:
The URL bar is empty, and only after the page finishes to load, the URL is shown

ER for STR #1:
The URL should be shown also when loading the page


STR #2:
* This STR may not be accurate but it seems to always work for me.
1. Install Nightly, Hebrew locale
2. Open www.google.com
3. Click the back button
4. Observe the URL bar

AR for STR #2:
The URL bar is empty, and a side effect is bug 1322144

ER for STR #2:
The URL should be shown

Note: it seems this bug is reproducible also on Ioana's Pixel Android 7.1.1 device, see attachment 8827972 [details].

Comment 1

[Max Liu [:maliu]]

Attachment: Bug 1331995 - Reset text direction to locale in order to reveal text hint,

Review commit: https://reviewboard.mozilla.org/r/116160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116160/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8842294 [details]
Bug 1331995 - Reset text direction to locale in order to reveal text hint,

https://reviewboard.mozilla.org/r/116160/#review117736

::: mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarDisplayLayout.java:248
(Diff revision 1)
>      }
>  
>      void setTitle(CharSequence title) {
>          mTitle.setText(title);
>  
> +        if(TextUtils.isEmpty(title)) {

nit: space after if.

Comment 3

[Max Liu [:maliu]]

Comment on attachment 8842294 [details]
Bug 1331995 - Reset text direction to locale in order to reveal text hint,

https://reviewboard.mozilla.org/r/116160/#review117756

Comment 4

[Max Liu [:maliu]]

Comment on attachment 8842294 [details]
Bug 1331995 - Reset text direction to locale in order to reveal text hint,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/116160/diff/1-2/

Comment 5

[Max Liu [:maliu]]

Comment on attachment 8842294 [details]
Bug 1331995 - Reset text direction to locale in order to reveal text hint,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/116160/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c6a264b47ece
Reset text direction to locale in order to reveal text hint, r=sebastian

Comment 7

[Max Liu [:maliu]]

Attachment: Bug 1331995 - Reset text direction to locale in order to reveal text hint, checkstyle,

Review commit: https://reviewboard.mozilla.org/r/116260/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116260/

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8842393 [details] [diff] [review]
Bug 1331995 - Reset text direction to locale in order to reveal text hint, checkstyle,

https://reviewboard.mozilla.org/r/116260/#review117808

Comment 9

[Max Liu [:maliu]]

Comment on attachment 8842393 [details] [diff] [review]
Bug 1331995 - Reset text direction to locale in order to reveal text hint, checkstyle,

https://reviewboard.mozilla.org/r/116260/#review117810

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32524eee28c5
Reset text direction to locale in order to reveal text hint, checkstyle, r=sebastian

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6a264b47ece
https://hg.mozilla.org/mozilla-central/rev/32524eee28c5

Comment 12

[Itiel]

I'm unable to reproduce the issue since the last few days, so this seems fixed to me.

Comment 13

[Kevin Brosnan [Ex-Mozilla]]

verified by comment 12

Comment 14

[Bogdan Surd, QA [:bsurd, NI]]

Device: Nexus 6 (Android 7.0)
Build: 54.0b4

I've also verified this issue and the URL bar was behaving as expected. Tried multiple scenarios and I was not able to reproduce the issue anymore.