Test framework for Reflect.parse does not check undefined

RESOLVED FIXED in Firefox 53

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: bakkot, Assigned: bakkot)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 months ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36

Steps to reproduce:

E.g. `assertStmt("throw 0;", void 0)` (equivalently `assertStmt("throw 0;")`) will pass. I'd expect it to fail.

This is masking a couple of typos in tests.

Patch incoming.
(Assignee)

Comment 1

3 months ago
Created attachment 8828068 [details] [diff] [review]
Fix framework and affected tests
Attachment #8828068 - Flags: review?(evilpies)
(Assignee)

Comment 2

3 months ago
Created attachment 8828071 [details] [diff] [review]
1332052.patch

(fix typo)
Attachment #8828068 - Attachment is obsolete: true
Attachment #8828068 - Flags: review?(evilpies)
Attachment #8828071 - Flags: review?(evilpies)
Comment on attachment 8828071 [details] [diff] [review]
1332052.patch

Review of attachment 8828071 [details] [diff] [review]:
-----------------------------------------------------------------

Good find!

::: js/src/tests/js1_8_5/reflect-parse/Match.js
@@ +73,4 @@
>              (typeof x === "string") ||
>              (typeof x === "boolean") ||
>              (x === null) ||
> +            (x === void 0) ||

undefined
Attachment #8828071 - Flags: review?(evilpies) → review+
(Assignee)

Comment 4

3 months ago
Created attachment 8828075 [details] [diff] [review]
1332052.patch

`void 0` -> `undefined`
Attachment #8828071 - Attachment is obsolete: true
Attachment #8828075 - Flags: review?(evilpies)
Comment on attachment 8828075 [details] [diff] [review]
1332052.patch

Thanks. Usually you don't have to request review again for trivial changes.
Attachment #8828075 - Flags: review?(evilpies) → review+

Updated

3 months ago
Assignee: nobody → bakkot
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c6423728ae9745c5f2bf317a0ecfe8a496518b21

Comment 7

3 months ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d33a2f279d13
Test framework for Reflect.parse now checks undefined. r=evilpie

Comment 8

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d33a2f279d13
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.