Closed Bug 1332052 Opened 9 years ago Closed 9 years ago

Test framework for Reflect.parse does not check undefined

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: bakkot, Assigned: bakkot)

Details

Attachments

(1 file, 2 obsolete files)

1332052.patch
5.09 KB, patch
evilpies
: review+
Details | Diff | Splinter Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36 Steps to reproduce: E.g. `assertStmt("throw 0;", void 0)` (equivalently `assertStmt("throw 0;")`) will pass. I'd expect it to fail. This is masking a couple of typos in tests. Patch incoming.
Attached patch Fix framework and affected tests (obsolete) — — Splinter Review
Attachment #8828068 - Flags: review?(evilpies)
Attached patch 1332052.patch (obsolete) — — Splinter Review
(fix typo)
Attachment #8828068 - Attachment is obsolete: true
Attachment #8828068 - Flags: review?(evilpies)
Attachment #8828071 - Flags: review?(evilpies)
Comment on attachment 8828071 [details] [diff] [review] 1332052.patch Review of attachment 8828071 [details] [diff] [review]: ----------------------------------------------------------------- Good find! ::: js/src/tests/js1_8_5/reflect-parse/Match.js @@ +73,4 @@ > (typeof x === "string") || > (typeof x === "boolean") || > (x === null) || > + (x === void 0) || undefined
Attachment #8828071 - Flags: review?(evilpies) → review+
Attached patch 1332052.patch — — Splinter Review
`void 0` -> `undefined`
Attachment #8828071 - Attachment is obsolete: true
Attachment #8828075 - Flags: review?(evilpies)
Comment on attachment 8828075 [details] [diff] [review] 1332052.patch Thanks. Usually you don't have to request review again for trivial changes.
Attachment #8828075 - Flags: review?(evilpies) → review+
Assignee: nobody → bakkot
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d33a2f279d13 Test framework for Reflect.parse now checks undefined. r=evilpie
https://hg.mozilla.org/mozilla-central/rev/d33a2f279d13
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: