Closed Bug 1332195 Opened 3 years ago Closed 3 years ago

Refine event handlers related to IPC

Categories

(Core :: User events and focus handling, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Some event handlers in TabChild, TabParent and PuppetWidget don't use "a" prefix for its argument. We should clean up them.
Yeah, I think bunch of IPC code uses still some random, not consistent even with itself coding style.
Comment on attachment 8828351 [details]
Bug 1332195 part.1 Event handlers in TabChild, TabParent and PuppetWidget should use "a" prefix for their arguments

https://reviewboard.mozilla.org/r/105802/#review106798

thanks, makes this code easier to read.
Attachment #8828351 - Flags: review?(bugs) → review+
Comment on attachment 8828352 [details]
Bug 1332195 part.2 Fix some nits of event handlers in TabChild, TabParent and PuppetWidget

https://reviewboard.mozilla.org/r/105804/#review106804
Attachment #8828352 - Flags: review?(bugs) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/6638661271a7
part.1 Event handlers in TabChild, TabParent and PuppetWidget should use "a" prefix for their arguments r=smaug
https://hg.mozilla.org/integration/autoland/rev/16f6a42267a0
part.2 Fix some nits of event handlers in TabChild, TabParent and PuppetWidget r=smaug
https://hg.mozilla.org/mozilla-central/rev/6638661271a7
https://hg.mozilla.org/mozilla-central/rev/16f6a42267a0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Component: Event Handling → User events and focus handling
You need to log in before you can comment on or make changes to this bug.