1332195 - Refine event handlers related to IPC

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Some event handlers in TabChild, TabParent and PuppetWidget don't use "a" prefix for its argument. We should clean up them.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Yeah, I think bunch of IPC code uses still some random, not consistent even with itself coding style.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3741de5a9cd

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1332195 part.1 Event handlers in TabChild, TabParent and PuppetWidget should use "a" prefix for their arguments

Review commit: https://reviewboard.mozilla.org/r/105802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105802/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1332195 part.2 Fix some nits of event handlers in TabChild, TabParent and PuppetWidget

This patch fixes:

* some long lines
* some odd indent
* wrapping one line blocks with {}
* removing B2G specific block

in event handlers in TabChild, TabParent and PuppetWidget.

Review commit: https://reviewboard.mozilla.org/r/105804/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/105804/

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8828351 [details]
Bug 1332195 part.1 Event handlers in TabChild, TabParent and PuppetWidget should use "a" prefix for their arguments

https://reviewboard.mozilla.org/r/105802/#review106798

thanks, makes this code easier to read.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8828352 [details]
Bug 1332195 part.2 Fix some nits of event handlers in TabChild, TabParent and PuppetWidget

https://reviewboard.mozilla.org/r/105804/#review106804

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6638661271a7
part.1 Event handlers in TabChild, TabParent and PuppetWidget should use "a" prefix for their arguments r=smaug
https://hg.mozilla.org/integration/autoland/rev/16f6a42267a0
part.2 Fix some nits of event handlers in TabChild, TabParent and PuppetWidget r=smaug

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6638661271a7
https://hg.mozilla.org/mozilla-central/rev/16f6a42267a0