1332237 - Investigate under what circumstances we can remove the soon-to-be-unused assets for recommended lightweight themes (LWTs)

Status: RESOLVED DUPLICATE of bug 1370919

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (out for now; he/him)]

See patch in bug 1323833 for context.

I *think* we create appropriately cached things when themes get used, and so short of a profile reset (which will wipe the data for these anyway because it's all in prefs), we should be able to remove the images. However, I'd really like to be sure that's the case before we do it, and for various complicated reasons I don't necessarily want to hold up the patch in bug 1323833 for this.

Jared, I remember we looked at the caching system etc. when fixing bug 1007336 and deciding on storage and so on... do you know whether my thinking above works and we can stop shipping the imagery?

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I'm not sure. I don't see anything within CustomizeMode.jsm or LightweightThemeManager.jsm that mentions creating cached versions. I know LightweightThemeImageOptimizer.jsm will crop the image to fit the current resolution, but it still depends on the source image to exist in the event that the screen resolution changes.

Comment 2

[:Gijs (out for now; he/him)]

bug 1370919 is basically the same. Forward-duping because that has clues about how we might fix this (using a UI migration to save copies of the files).