1332288 - Cached http -> https redirects are notified to History:VisitURL with incorrect response codes (200 instead of 300), causing history to be confused

Status: NEW

(Core :: Networking: HTTP, defect, P3)

Description

[Mark Banner (:standard8)]

In researching issues surrounding bug 737836, I've found an issue somewhere in the docshell/http channel code.

STR

1) In `nsDocShell::AddURIVisit` add a printf just before the `history->VisitURI` call. Log the uri, response status and uri flags.

2) Visit "www.mozillamessaging.com"

=> Logged:

a) http://www.mozillamessaging.com/ 302 9 (top-level, redirect source)
b) http://www.mozilla.org/thunderbird/ 301 13 (top-level, redirect source, redirect temporary)
c) https://www.mozilla.org/thunderbird/ 301 11 (top-level, redirect source, redirect permanent)
d) https://www.mozilla.org/en-US/thunderbird/ 200 3 (top-level, redirect permanent)

3) Open a new tab, close the old one.

4) Visit "www.mozillamessaging.com" again

=> Logged:

e) http://www.mozillamessaging.com/ 302 9 (top-level, redirect source)
f) http://www.mozilla.org/thunderbird/ 200 5 (top-level, redirect temporary)
g) https://www.mozilla.org/thunderbird/ 301 11 top-level, redirect source, redirect permanent)
h) https://www.mozilla.org/en-US/thunderbird/ 200 3 (top-level, redirect permanent)

As can be seen, b) and f) show different results. With the second and subsequent visits, its response is treated as page loaded OK, rather than a redirect.

This end effect of this, is that it is causing http://www.mozilla.org/thunderbird/ to be prioritised, and g) and h) currently aren't displayed in the urlbar results at all.

Comment 1

[Mark Banner (:standard8)]

This could be related to bug 759043, but its unclear if that's the actual cause, or if this could be a specific side-effect.

Comment 2

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258