Closed
Bug 1332353
Opened 8 years ago
Closed 8 years ago
Introduce more clarity into whether a stylesheet is owned by a document
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
22.24 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
Right now we have this SetOwningDocument thing, but for editor override sheets the document doesn't actually own the sheet; the editor does. This makes it hard to reason about sheet lifetime optimizations in the cycle collector. I'm going to rejigger the API to make it clear what's really going on.
|
||
Updated•8 years ago
|
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8828453 -
Flags: review?(cam)
|
||
Comment 2•8 years ago
|
||
Note that this patch will conflict with bug 1328420, so whoever lands second will have to do some rebasing.
|
|
Assignee | |
Comment 3•8 years ago
|
||
Thanks for the heads-up.
|
|
||
Updated•8 years ago
|
Attachment #8828453 -
Flags: review?(cam) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2b1fcb4b8c88 Make it clearer when a stylesheet is really owned by its mDocument. r=heycam
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2b1fcb4b8c88
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•