Closed Bug 1332354 Opened 3 years ago Closed 3 years ago

Allow enabling cubeb log by flipping a pref

Categories

(Core :: Audio/Video: cubeb, defect, P2)

50 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: padenot, Assigned: padenot)

Details

Attachments

(1 file)

No description provided.
Attachment #8828394 - Flags: review?(kinetik)
Assignee: nobody → padenot
Status: NEW → ASSIGNED
Rank: 21
Priority: -- → P2
Comment on attachment 8828394 [details] [diff] [review]
Allow enabling cubeb log by flipping a pref

Review of attachment 8828394 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments addressed

::: dom/media/CubebUtils.cpp
@@ +21,5 @@
>  
>  #define PREF_VOLUME_SCALE "media.volume_scale"
>  #define PREF_CUBEB_LATENCY_PLAYBACK "media.cubeb_latency_playback_ms"
>  #define PREF_CUBEB_LATENCY_MSG "media.cubeb_latency_msg_frames"
> +#define PREF_CUBEB_LOG "media.cubeb.loglevel"

Make it PREF_CUBEB_LOG_LEVEL and media.cubeb.log_level

@@ +333,5 @@
>  {
>    Preferences::UnregisterCallback(PrefChanged, PREF_VOLUME_SCALE);
>    Preferences::UnregisterCallback(PrefChanged, PREF_CUBEB_LATENCY_PLAYBACK);
>    Preferences::UnregisterCallback(PrefChanged, PREF_CUBEB_LATENCY_MSG);
> +  Preferences::RegisterCallback(PrefChanged, PREF_CUBEB_LOG);

This should be UnregisterCallback

::: modules/libpref/init/all.js
@@ +597,5 @@
>  // Whether to check the decoder supports recycling.
>  pref("media.decoder.recycle.enabled", false);
>  
> +// Log level for cubeb, the audio input/output system. Valid values are
> +// "verbose" and "normal".

Valid values are "verbose", "normal", and ""/empty string.
Attachment #8828394 - Flags: review?(kinetik) → review+
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13545155cfc0
Allow enabling cubeb log by flipping a pref. r=kinetik
https://hg.mozilla.org/mozilla-central/rev/13545155cfc0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.