1332422 - CSP should not use 'aExtra' to indicate redirects within ContentPolicy

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P3)

Description

[Christoph Kerschbaumer [:ckerschb]]

nsIContentPolicy states

   * @param aExtra            an OPTIONAL argument, pass-through for non-Gecko
   *                          callers to pass extra data to callees.

CSP should not use aExtra to indicate redirects instead CSP should call a non public API.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: csp_blockedURI4.patch

I don't know if this is what we want, but working on other CSP related things, I removed this aExtra parameter, passing a nsIURI object directly when needed.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Comment on attachment 8992907 [details] [diff] [review]
csp_blockedURI4.patch

Review of attachment 8992907 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for cleaning that up. r=me

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a66951dd403
CSP should not use 'aExtra' to indicate redirects within ContentPolicy, r=ckerschb

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/8a66951dd403