1332496 - Uninstalling a 64-bit build does not automatically remove the maintenance service

Status: VERIFIED FIXED

(Firefox :: Installer, defect, P3)

Description

[Molly Howell (she/her) (no longer active)]

When uninstalling a product which can use the Mozilla Maintenance Service to perform application updates, the uninstaller checks to see if it is the only application on the system which is registered with the service. If so, it also runs the maintenance service uninstaller. This does not appear to work if that application is a 64-bit build.

The cause is probably that the wrong registry view is set when reading the path to the maintenance service uninstaller, since those uninstall entries are written in the 32-bit view (i.e., WOW6432Node), but other maintenance service keys are written in the native view.

Comment 1

[Molly Howell (she/her) (no longer active)]

I don't think this is serious enough to block 64-bit rollout (bug 797208), since few users would ever notice it and it doesn't do any real harm.

Comment 2

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1332496 - Fix 64-bit uninstaller failing to automatically remove maintenance service;

There are two parts to this patch:
1) The maintenance service installer now writes its uninstall registry keys to
the same registry view (either 32-bit or 64-bit) that it uses for all its other
registry keys. Previously it would always use the 32-bit view.
2) The Firefox uninstaller now looks in both views to find the path to the
maintenance service uninstaller. Previously it looked only in the native view.
This change was made in addition to #1 so that we have a fix for the bug that
will get delivered in an update, as opposed to requiring a reinstall.

Review commit: https://reviewboard.mozilla.org/r/106188/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106188/

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 8828959 [details]
Bug 1332496 - Fix 64-bit uninstaller failing to automatically remove maintenance service;

https://reviewboard.mozilla.org/r/106188/#review108112

::: browser/installer/windows/nsis/maintenanceservice_installer.nsi:194
(Diff revision 1)
>    WriteUninstaller "$INSTDIR\Uninstall.exe"
> +
> +  ; Since the Maintenance service can be installed either x86 or x64,
> +  ; always use the 64-bit registry.
> +  ${If} ${RunningX64}
> +    SetRegView 64

I don't see any cleanup for 64 bit systems that have the uninstall string written to the 32 bit registry. How is this handled?

Clearing review for the answer to this.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 8828959 [details]
Bug 1332496 - Fix 64-bit uninstaller failing to automatically remove maintenance service;

https://reviewboard.mozilla.org/r/106188/#review108114

Comment 5

[Molly Howell (she/her) (no longer active)]

Comment on attachment 8828959 [details]
Bug 1332496 - Fix 64-bit uninstaller failing to automatically remove maintenance service;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106188/diff/1-2/

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 8828959 [details]
Bug 1332496 - Fix 64-bit uninstaller failing to automatically remove maintenance service;

https://reviewboard.mozilla.org/r/106188/#review109680

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f00eae7c948
Fix 64-bit uninstaller failing to automatically remove maintenance service; r=rstrong

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7f00eae7c948

Comment 9

[Molly Howell (she/her) (no longer active)]

Comment on attachment 8828959 [details]
Bug 1332496 - Fix 64-bit uninstaller failing to automatically remove maintenance service;

Approval Request Comment
[Feature/Bug causing the regression]:
Bug 797208 (which landed in 53) made this a problem for many more users by making 64-bit installs the default, but this bug has probably always been present in 64-bit Windows builds.

[User impact if declined]:
Additional steps needed to completely uninstall Firefox beyond running the Firefox uninstaller.

[Is this code covered by automated tests?]:
No.

[Has the fix been verified in Nightly?]:
Yes.

[Needs manual test from QE? If yes, steps to reproduce]: 
No, I've tested it manually myself using an official Nightly build.

[List of other uplifts needed for the feature/fix]:
None.

[Is the change risky?]:
No.

[Why is the change risky/not risky?]:
It's a small and straightforward change, and doesn't affect any browser functionality, only the uninstaller.

[String changes made/needed]:
None

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8828959 [details]
Bug 1332496 - Fix 64-bit uninstaller failing to automatically remove maintenance service;

Since this problem was exacerbated in 53 let's uplift to aurora.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ba5398b3f6fc

Comment 12

[Andrei Vaida [:avaida]]

Flagging this for manual testing on Fx53.

Comment 13

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

I reproduced the issue on 53.0a2 (2017-02-01). The bug is verified fixed on 53.0b1 build1 (20170307064827), using Windows 10 x64. Also, based on comment 9, the bug is verified fixed for the 54 build, too.