RESOLVED FIXED in Firefox 53

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla53
Points:
---

Firefox Tracking Flags

(thunderbird_esr45+, thunderbird_esr52+ affected, firefox51 wontfix, firefox52 affected, firefox-esr52 affected, firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
More specifically, the part about zone_force_unlock. The refactor is not necessary.
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8828606 [details]
Bug 1332508 - Reinitialize allocator mutexes in fork() child processes.

https://reviewboard.mozilla.org/r/105932/#review106896
Attachment #8828606 - Flags: review?(n.nethercote) → review+

Comment 5

2 years ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/516551993d16
Reinitialize allocator mutexes in fork() child processes. r=njn

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/516551993d16
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53

Comment 7

2 years ago
Not sure if we would apply it to TB esr45, but we should consider for 52 if mozilla does not take it.
tracking-thunderbird_esr45: --- → +
(Assignee)

Comment 8

2 years ago
Comment on attachment 8828606 [details]
Bug 1332508 - Reinitialize allocator mutexes in fork() child processes.

Approval Request Comment
[Feature/Bug causing the regression]: Low-level system library changes in OSX 10.12
[User impact if declined]: Theoretical chances of deadlocks when forking subprocesses (for e.g. e10s or plugins) on OSX 10.12. Not formally observed, though.
[Is this code covered by automated tests?]: Yes and no. That is, the code being changed is pretty much exercised by anything that will cause subprocesses to start, and if it caused problems, we'd have seen them already.
[Has the fix been verified in Nightly?]: That it doesn't break anything, yes. That it actually fixes the theoretical deadlocks has not been observed (the deadlocks haven't been observed in the wild in the first place ; at least I'm not aware of such reports).
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: this fix depends on the changes from bug 1286613. It /is/ possible to come up with a different patch to fix the same issue on beta if bug 1286613 is not approved.
[Is the change risky?]: No
[Why is the change risky/not risky?]: See "Is this code covered by automated tests?"
[String changes made/needed]: None
Attachment #8828606 - Flags: approval-mozilla-beta?
status-firefox51: --- → wontfix
status-firefox52: --- → affected
status-firefox-esr52: --- → affected
Comment on attachment 8828606 [details]
Bug 1332508 - Reinitialize allocator mutexes in fork() child processes.

Declining for beta as the dependency on bug 1286613 makes this quite intrusive.
Attachment #8828606 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

Comment 10

2 years ago
Uplifted to THUNDERBIRD520b2_2017020901_RELBRANCH branch:
https://hg.mozilla.org/releases/mozilla-beta/rev/5f22c17aeac2

Updated

2 years ago
status-thunderbird_esr52: --- → affected
tracking-thunderbird_esr52: --- → +
You need to log in before you can comment on or make changes to this bug.