1332516 - Intermittent browser/base/content/test/webrtc/browser_devices_get_user_media_unprompted_access_tear_off_tab.js | expected notification getUserMedia:response:allow - Got undefined, expected 1

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=70497405&repo=autoland

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-win64-debug/1484868205/autoland_win8_64-debug_test-mochitest-browser-chrome-1-bm109-tests1-windows-build274.txt.gz

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This looks like fallout from bug 1270572. mchiang, can you take a look at this, please? Thank you.

Comment 2

[Intermittent Failures Robot]

31 failures in 143 pushes (0.217 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-inbound: 14
* autoland: 14
* graphics: 2
* mozilla-central: 1

Platform breakdown:
* windows8-64: 31

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332516&startday=2017-01-20&endday=2017-01-20&tree=all

Comment 3

[Intermittent Failures Robot]

39 failures in 690 pushes (0.057 failures/push) were associated with this bug in the last 7 days. 

This is the #40 most frequent failure this week. 

Repository breakdown:
* mozilla-inbound: 20
* autoland: 14
* graphics: 3
* mozilla-central: 2

Platform breakdown:
* windows8-64: 39

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332516&startday=2017-01-16&endday=2017-01-22&tree=all

Comment 4

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Attachment: Bug 1332516 - Fix Intermittent browser_devices_get_user_media_unprompted_access_tear_off_tab.js;

Review commit: https://reviewboard.mozilla.org/r/106488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106488/

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8829357 [details]
Bug 1332516 - Fix Intermittent browser_devices_get_user_media_unprompted_access_tear_off_tab.js;

https://reviewboard.mozilla.org/r/106488/#review108338

Your commit message says "Fix ... by adding an argument", I don't see how that relates to what's in the patch. Could you please explain?

::: browser/base/content/test/webrtc/browser_devices_get_user_media_unprompted_access_tear_off_tab.js:42
(Diff revision 1)
>      gBrowser.selectedBrowser.messageManager.loadFrameScript(CONTENT_SCRIPT_HELPER, true);
>  
>      info("request audio+video and check if there is no prompt");
>      yield promiseRequestDevice(true, true, null, null, win.gBrowser.selectedBrowser);
>      yield promiseObserverCalled("getUserMedia:request");
> -    yield promiseNoPopupNotification("webRTC-shareDevices");
> +    let promises = [promiseObserverCalled("getUserMedia:response:allow"),

Why are you removing the check that we don't have a permission prompt shown in the UI?

::: browser/base/content/test/webrtc/browser_devices_get_user_media_unprompted_access_tear_off_tab.js:47
(Diff revision 1)
> -    yield promiseNoPopupNotification("webRTC-shareDevices");
> -    yield expectObserverCalled("getUserMedia:response:allow");
> -    yield expectObserverCalled("recording-device-events");
> +    let promises = [promiseObserverCalled("getUserMedia:response:allow"),
> +                    promiseObserverCalled("recording-device-events")];
> +    yield Promise.all(promises);
>  
> -    let promises = [promiseObserverCalled("recording-device-events"),
> +    promises = [promiseObserverCalled("recording-device-events"),
>                      promiseObserverCalled("recording-device-events"),

The indent is broken here.

Comment 6

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Comment on attachment 8829357 [details]
Bug 1332516 - Fix Intermittent browser_devices_get_user_media_unprompted_access_tear_off_tab.js;

https://reviewboard.mozilla.org/r/106488/#review108338

Sorry I mixed up, adding an argument should be for another bug (javascript error).

> Why are you removing the check that we don't have a permission prompt shown in the UI?

Just think that checking getUserMedia:response:allow is sufficient to assure there is no prompt. Will add it back.

Comment 7

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Comment on attachment 8829357 [details]
Bug 1332516 - Fix Intermittent browser_devices_get_user_media_unprompted_access_tear_off_tab.js;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106488/diff/1-2/

Comment 8

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4a41c2a93b82981207c97f49459728b84b82d67

Comment 9

[Florian Quèze [:florian]]

Comment on attachment 8829357 [details]
Bug 1332516 - Fix Intermittent browser_devices_get_user_media_unprompted_access_tear_off_tab.js;

https://reviewboard.mozilla.org/r/106488/#review108536

Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41b7e94d14fc
Fix Intermittent browser_devices_get_user_media_unprompted_access_tear_off_tab.js; r=florian

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/41b7e94d14fc

Comment 12

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Comment on attachment 8829357 [details]
Bug 1332516 - Fix Intermittent browser_devices_get_user_media_unprompted_access_tear_off_tab.js;

Approval Request Comment
[Feature/Bug causing the regression]: bug 1270572
[User impact if declined]: intermittent mochitest failure
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: it only modifies mochitest
[String changes made/needed]: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8829357 [details]
Bug 1332516 - Fix Intermittent browser_devices_get_user_media_unprompted_access_tear_off_tab.js;

test-only changes don't need approval for uplift

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c748e16d9ec7

Comment 15

[Intermittent Failures Robot]

16 failures in 749 pushes (0.021 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* mozilla-central: 6
* autoland: 5
* mozilla-inbound: 3
* mozilla-aurora: 2

Platform breakdown:
* windows8-64: 15
* osx-10-10: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1332516&startday=2017-01-23&endday=2017-01-29&tree=all