Closed Bug 1332561 Opened 4 years ago Closed 4 years ago

Enable async video frame update in WebRenderImageLayer

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 1 obsolete file)

WebRenderImageLayer does not use async image rendering. All video update is done via main thread. We need to enable it.
Blocks: webrender
Assignee: nobody → sotaro.ikeda.g
Summary: Enable async video frame update → Enable async video frame update in WebRenderImageLayer
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/585ed02acd43
Enable async video frame update in WebRenderImageLayer r=nical?
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Attachment #8828704 - Flags: review?(nical.bugzilla)
Comment on attachment 8828704 [details] [diff] [review]
patch - Enable async video frame update in WebRenderImageLayer

Review of attachment 8828704 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderImageLayer.cpp
@@ +90,4 @@
>      return;
>    }
>  
> +  MOZ_ASSERT(GetImageClientType() != CompositableType::UNKNOWN);

nit: maybe not necessary to assert this just after a a branch that trivially prevents it.
Attachment #8828704 - Flags: review?(nical.bugzilla) → review+
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.