1332584 - MediaRecorder doesn't record the last frame of a video track

Status: RESOLVED FIXED

(Core :: Audio/Video: Recording, defect, P2)

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1332584 - Append last frame on EOS in VideoTrackEncoder.

Review commit: https://reviewboard.mozilla.org/r/106074/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106074/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8828791 [details]
Bug 1332584 - Append last frame on EOS in VideoTrackEncoder.

https://reviewboard.mozilla.org/r/106074/#review107050

::: dom/media/encoder/TrackEncoder.cpp:410
(Diff revision 1)
> +               RateConvertTicksRoundUp(PR_USEC_PER_SEC, mTrackRate,
> +                                       mLastChunk.mDuration) / 1000000.0));

wouldn't the last constant also be PR_USEC_PER_SEC?

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1332584 - Use time conversion utils from VideoUtils.

Review commit: https://reviewboard.mozilla.org/r/106134/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106134/

Comment 4

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8828791 [details]
Bug 1332584 - Append last frame on EOS in VideoTrackEncoder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106074/diff/1-2/

Comment 5

[Andreas Pehrson [:pehrsons]]

These both fixes the issue in this try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8dc6c08e8ed6
and moves away from PR_USEC_TO_SEC to address your last comment.

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8828909 [details]
Bug 1332584 - Use time conversion utils from VideoUtils.

https://reviewboard.mozilla.org/r/106134/#review107132

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8828791 [details]
Bug 1332584 - Append last frame on EOS in VideoTrackEncoder.

https://reviewboard.mozilla.org/r/106074/#review107136

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17f78bed73c2
Append last frame on EOS in VideoTrackEncoder. r=jesup
https://hg.mozilla.org/integration/mozilla-inbound/rev/3be7e027a50b
Use time conversion utils from VideoUtils. r=jesup

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/17f78bed73c2
https://hg.mozilla.org/mozilla-central/rev/3be7e027a50b