Closed
Bug 1332585
Opened 3 years ago
Closed 3 years ago
Add some VideoTrackEncoder unit tests
Categories
(Core :: Audio/Video: Recording, defect)
Core
Audio/Video: Recording
Not set
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
Details
Attachments
(7 files)
|
59 bytes,
text/x-review-board-request
|
jesup
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jesup
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jesup
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jesup
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jesup
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jesup
:
review+
|
Details |
|
59 bytes,
text/x-review-board-request
|
jesup
:
review+
|
Details |
We have some gtest unit tests for VideoTrackEncoder, but they're very very basic. It should be a simple task to add a couple more.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 7•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8828797 [details] Bug 1332585 - Add gtest for starting a track with null frames. https://reviewboard.mozilla.org/r/106088/#review107052
Attachment #8828797 -
Flags: review?(rjesup) → review+
|
|
||
Comment 8•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8828794 [details] Bug 1332585 - Fix first frame duration being counted twice. https://reviewboard.mozilla.org/r/106082/#review107054
Attachment #8828794 -
Flags: review?(rjesup) → review+
|
|
||
Comment 9•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8828795 [details] Bug 1332585 - Check that encoder completed after EOS in existing test. https://reviewboard.mozilla.org/r/106084/#review107056
Attachment #8828795 -
Flags: review?(rjesup) → review+
|
|
||
Comment 10•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8828796 [details] Bug 1332585 - Add gtest for passing multiple instances of one frame to the vp8 encoder. https://reviewboard.mozilla.org/r/106086/#review107058
Attachment #8828796 -
Flags: review?(rjesup) → review+
|
|
||
Comment 11•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8828793 [details] Bug 1332585 - Add gtest for encoding a single frame. https://reviewboard.mozilla.org/r/106080/#review107060
Attachment #8828793 -
Flags: review?(rjesup) → review+
|
|
||
Comment 12•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8828792 [details] Bug 1332585 - Make VP8TrackEncoderTest's buffer generator more explicit. https://reviewboard.mozilla.org/r/106078/#review107062
Attachment #8828792 -
Flags: review?(rjesup) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
||
Comment 20•3 years ago
|
||
| mozreview-review | ||
Comment on attachment 8828910 [details] Bug 1332585 - Protect TrackEncoder members from races. https://reviewboard.mozilla.org/r/106136/#review107138
Attachment #8828910 -
Flags: review?(rjesup) → review+
|
||
Comment 21•3 years ago
|
||
Pushed by pehrsons@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/76f2c83d048c Make VP8TrackEncoderTest's buffer generator more explicit. r=jesup https://hg.mozilla.org/integration/mozilla-inbound/rev/60d77d6c0bec Add gtest for encoding a single frame. r=jesup https://hg.mozilla.org/integration/mozilla-inbound/rev/d7538cc4bf1e Fix first frame duration being counted twice. r=jesup https://hg.mozilla.org/integration/mozilla-inbound/rev/aabc216236c1 Check that encoder completed after EOS in existing test. r=jesup https://hg.mozilla.org/integration/mozilla-inbound/rev/c577910143c2 Add gtest for passing multiple instances of one frame to the vp8 encoder. r=jesup https://hg.mozilla.org/integration/mozilla-inbound/rev/9e240bc4bd3a Add gtest for starting a track with null frames. r=jesup https://hg.mozilla.org/integration/mozilla-inbound/rev/f5a4d8f2a6e4 Protect TrackEncoder members from races. r=jesup
|
||
Comment 22•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/76f2c83d048c https://hg.mozilla.org/mozilla-central/rev/60d77d6c0bec https://hg.mozilla.org/mozilla-central/rev/d7538cc4bf1e https://hg.mozilla.org/mozilla-central/rev/aabc216236c1 https://hg.mozilla.org/mozilla-central/rev/c577910143c2 https://hg.mozilla.org/mozilla-central/rev/9e240bc4bd3a https://hg.mozilla.org/mozilla-central/rev/f5a4d8f2a6e4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•