Need to be more conservative about using mmap in registry

RESOLVED WONTFIX

Status

SeaMonkey
Build Config
P3
normal
RESOLVED WONTFIX
18 years ago
13 years ago

People

(Reporter: shaver, Assigned: shaver)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Ramiro writes:
> shaver (or anyone): You should preempt all these dumb unices by doing
> this in configure.in:
>
>     case "$target" in
>         *-linux*|*-solaris*)
>             MOZ_MMAP=1
>         ;;
>    esac
>
> and then use MOZ_MMAP instead of XP_UNIX in reg.c.

Maybe we want --(en|dis)able-registry-mmap to allow easy override/testing as
well?
Status: NEW → ASSIGNED
Target Milestone: M11
This is M11 for sure; don't want the beta tripping on weak MMAP implementations.
I've made some changes (not yet checked in) so that USE_MMAP_REGISTRY_IO needs
to be defined in the makefile rather than just being turned on in the header
file for XP_UNIX.  This is so we could easily switch on
USE_BUFFERED_REGISTRY_IO instead which is home-grown buffering because the Mac
doesn't support mmapio.  If it performs well enough we could just use BUFFERED
for everyone, otherwise use mmapio for those systems that support it.
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → WONTFIX
We're not using mmap here anymore, so I guess I'm off the hook.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.