Closed Bug 1332622 Opened 3 years ago Closed 3 years ago

Remove MOZILLA_INTERNAL_API code from webrtc

Categories

(Core :: WebRTC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

Details

Attachments

(1 file)

We have code conditionally compiled using the MOZILLA_INTERNAL_API macro. This should no longer be necessary and can be removed.
Blocks: 1332639
I really want bug 1332639 to happen! Can I help? Is this just as simple as removing all the MOZILLA_INTERNAL_API paths?
Flags: needinfo?(dminor)
I was waiting to work on this until the cleanup over in Bug 1319489 landed. Since I have r+ on the relevant patches, I'll land those now and get started on this shortly. Thanks for offering to help!
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Rank: 19
Flags: needinfo?(dminor)
Comment on attachment 8839927 [details]
Bug 1332622 - Remove MOZILLA_INTERNAL_API macro from webrtc;

https://reviewboard.mozilla.org/r/114496/#review116724

::: media/webrtc/signaling/signaling.gyp:261
(Diff revision 1)
>            'defines' : [
> -            'MOZILLA_INTERNAL_API',
>            ],

Remove empty 'defines'
Attachment #8839927 - Flags: review?(rjesup) → review+
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/be46bf0c2fd6
Remove MOZILLA_INTERNAL_API macro from webrtc; r=jesup
https://hg.mozilla.org/mozilla-central/rev/be46bf0c2fd6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.