Closed Bug 1332622 Opened 3 years ago Closed 3 years ago
_INTERNAL _API code from webrtc
59 bytes, text/x-review-board-request
We have code conditionally compiled using the MOZILLA_INTERNAL_API macro. This should no longer be necessary and can be removed.
I really want bug 1332639 to happen! Can I help? Is this just as simple as removing all the MOZILLA_INTERNAL_API paths?
I was waiting to work on this until the cleanup over in Bug 1319489 landed. Since I have r+ on the relevant patches, I'll land those now and get started on this shortly. Thanks for offering to help!
Assignee: nobody → dminor
Status: NEW → ASSIGNED
Comment on attachment 8839927 [details] Bug 1332622 - Remove MOZILLA_INTERNAL_API macro from webrtc; https://reviewboard.mozilla.org/r/114496/#review116724 ::: media/webrtc/signaling/signaling.gyp:261 (Diff revision 1) > 'defines' : [ > - 'MOZILLA_INTERNAL_API', > ], Remove empty 'defines'
Attachment #8839927 - Flags: review?(rjesup) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/be46bf0c2fd6 Remove MOZILLA_INTERNAL_API macro from webrtc; r=jesup
You need to log in before you can comment on or make changes to this bug.