1332622 - Remove MOZILLA_INTERNAL_API code from webrtc

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Dan Minor [:dminor]]

We have code conditionally compiled using the MOZILLA_INTERNAL_API macro. This should no longer be necessary and can be removed.

Comment 1

[(Away)]

I really want bug 1332639 to happen! Can I help? Is this just as simple as removing all the MOZILLA_INTERNAL_API paths?

Comment 2

[Dan Minor [:dminor]]

I was waiting to work on this until the cleanup over in Bug 1319489 landed. Since I have r+ on the relevant patches, I'll land those now and get started on this shortly. Thanks for offering to help!

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1332622 - Remove MOZILLA_INTERNAL_API macro from webrtc;

I've also cleaned up a few leftover references to USE_FAKE_MEDIA_STREAMS,
MOZILLA_EXTERNAL_LINKAGE and MOZ_WIDGET_GONK where I noticed them.

Review commit: https://reviewboard.mozilla.org/r/114496/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/114496/

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8839927 [details]
Bug 1332622 - Remove MOZILLA_INTERNAL_API macro from webrtc;

https://reviewboard.mozilla.org/r/114496/#review116724

::: media/webrtc/signaling/signaling.gyp:261
(Diff revision 1)
>            'defines' : [
> -            'MOZILLA_INTERNAL_API',
>            ],

Remove empty 'defines'

Comment 5

[Dan Minor [:dminor]]

Comment on attachment 8839927 [details]
Bug 1332622 - Remove MOZILLA_INTERNAL_API macro from webrtc;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/114496/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be46bf0c2fd6
Remove MOZILLA_INTERNAL_API macro from webrtc; r=jesup

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/be46bf0c2fd6