Remove 'retentionDays' from sendTelemetryPing call in CrashManager.jsm

RESOLVED FIXED in Firefox 54

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: marco, Assigned: kevin.gay, Mentored)

Tracking

(Blocks: 1 bug, {good-first-bug})

unspecified
mozilla54
good-first-bug
Points:
1

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [measurement:client][lang=js])

Attachments

(1 attachment, 1 obsolete attachment)

Blocks: 1201022
Mentor: gfritzsche, alessio.placitelli
Priority: -- → P3
Whiteboard: [measurement:client][lang=js]
(Assignee)

Comment 1

2 years ago
Created attachment 8829338 [details]
CrashManager.jsm removed retentionDays
(Assignee)

Updated

2 years ago
Attachment #8829338 - Attachment is patch: false
Hi Kevin, welcome and thanks for picking this bug!

Do you need any help with this bug? I noticed you attached the CrashManager.jsm file updated with the requested changes. Unfortunately, we need a patch file in order to check in your changes.

If you don't know how to generate a patch file, please see here: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Do not hesitate to ask if you have questions!
Flags: needinfo?(kevin.gay)
(Assignee)

Comment 3

2 years ago
Created attachment 8829397 [details] [diff] [review]
CrashManager.jsm.patch
Attachment #8829338 - Attachment is obsolete: true
Assignee: nobody → kevin.gay
Status: NEW → ASSIGNED
Points: --- → 1
Comment on attachment 8829397 [details] [diff] [review]
CrashManager.jsm.patch

Review of attachment 8829397 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good Kevin, thank you for the patch!
Attachment #8829397 - Flags: review+
This is simple enough to not require a push to try (we're removing a leftover argument that's not used anymore). It works locally.
Flags: needinfo?(kevin.gay)
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/406caf9e8cfa
Remove 'retentionDays' from sendTelemetryPing call in CrashManager.jsm. r=Dexter
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/406caf9e8cfa
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.