1332687 - Merge the --enable-clang-plugin and stylo llvm-configure discovery codepaths

Status: NEW

(Firefox Build System :: General, defect, P5)

Description

[Nika Layzell [:nika] (ni? for response)]

When building stylo, bindgen is used to generate rust bindings to the c++ classes. In order to build this, the location of the llvm-config binary must be discovered.

We also perform this discovery for building the clang plugin with --enable-clang-plugin. Currently this has two different codepaths, but we should merge them together.

Comment 1

[(no longer active)]

Where is the code path you proposed to be merged?

Comment 2

[Nika Layzell [:nika] (ni? for response)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/210b8d21be06#l1.21 is the new code for stylo IIRC (currently only on inbound).

This would probably be merged somehow with 

http://searchfox.org/mozilla-central/rev/30fcf167af036aeddf322de44a2fadd370acfd2f/build/autoconf/clang-plugin.m4#16-28

Comment 3

[(no longer active)]

Copying what I said on bug 1332689:

Ugh, it sucks that this wasn't caught at review time.  This code isn't even using the same environment variable name.  Sigh. :(

Comment 4

[Chris Peterson [:cpeterson]]

status-firefox57=wontfix unless someone thinks this bug should block 57