1332757 - With modal find-in-page, Ctrl+G highlights the current findbar contents, so additional typed characters *replace* instead of extending your search term

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Daniel Holbert [:dholbert]]

Suppose you want to look through the instances of the word "grow" in https://www.w3.org/TR/css-flexbox-1/

STR:
 1. Visit https://www.w3.org/TR/css-flexbox-1/

 2. Ctrl+F to open findbar.

 3. Type "gro".

 4. Hit Ctrl+G a few times to skip through the results.
(Notice that you're getting hits for "group", which you're not interested in. So, you'll need to continue typing.)

 5. Type "w"

EXPECTED RESULTS:
 - Findbar should be left with "grow"
 - Find-in-page should have jumped to an instance of that word.

ACTUAL RESULTS:
 - Findbar is left with "w", and find-in-page is showing me all the instances of "w".
 - Specifically, in step 4, my Ctrl+G action caused the findbar contents to be *fully selected* for some reason!
 - So in step 5, when I type "w", it stomps on the current findbar contents -- it stomps on my partially entered word that I wanted to continue entering.

This seems to be a regression, caused by the modal find-in-page feature. If I disable the "findbar.modalHighlight" pref, I get EXPECTED RESULTS.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screencast of STR & buggy result (findbar getting highlighted + stomped on)

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: screencast of STR & expected results (with feature preffed off)

Comment 3

[Daniel Holbert [:dholbert]]

This has been a particular pain point for me with modal find-in-page, BTW.  I perform something like the STR quite frequently when searching through code during my day to day work.  I type part of a variable/function name into the findbar, and skip forward through a few hits, and I discover that I need to be more specific, so I continue typing, and then realize that I've now stomped on the partially-entered word due to the fact that the findbar highlighted itself on my first Ctrl+G action.

This has been an issue with this new feature for a while, but I haven't gotten around to reporting it (I think) until now. Apologies if it's been previously reported.

Comment 4

[Mike de Boer [:mikedeboer]]

Hi Daniel, it has not been reported as of yet, so thanks for that! I will fix it asap.

Comment 5

[Nathan Froyd [:froydnj]]

(In reply to Mike de Boer [:mikedeboer] from comment #4)
> Hi Daniel, it has not been reported as of yet, so thanks for that! I will
> fix it asap.

It was reported as bug 1310797. =/

Comment 6

[Mike de Boer [:mikedeboer]]

Hi Nathan, my apologies! It appears that I 'overlooked' that one as it seemed a little less serious at the time compared to the swath of other bugs I was looking into.
Would you mind if I dupe your bug to this one as it contains screenshots and other info?

Comment 8

[Nathan Froyd [:froydnj]]

(In reply to Mike de Boer [:mikedeboer] from comment #6)
> Hi Nathan, my apologies! It appears that I 'overlooked' that one as it
> seemed a little less serious at the time compared to the swath of other bugs
> I was looking into.

No problem!

> Would you mind if I dupe your bug to this one as it contains screenshots and
> other info?

Done, thanks!

Comment 9

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1332757 - don't select the findbar input field contents upon find-again when modal highlighting is enabled.

Review commit: https://reviewboard.mozilla.org/r/106518/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106518/

Comment 10

[:Gijs (he/him)]

Comment on attachment 8829402 [details]
Bug 1332757 - don't select the findbar input field contents upon find-again when modal highlighting is enabled.

https://reviewboard.mozilla.org/r/106518/#review107784

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d385f49428c2
don't select the findbar input field contents upon find-again when modal highlighting is enabled. r=Gijs

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d385f49428c2

Comment 13

[Ryan VanderMeulen [:RyanVM]]

This was a trunk-only issue, correct?

Comment 14

[Daniel Holbert [:dholbert]]

This is a long-standing issue, but it looks like this feature is only enabled in Nightly for now...
  https://dxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#648-650
...so I suspect RyanVM is right - we don't need to worry about other branches (not their default configuration at least).