Closed
Bug 1332757
Opened 7 years ago
Closed 7 years ago
With modal find-in-page, Ctrl+G highlights the current findbar contents, so additional typed characters *replace* instead of extending your search term
Categories
(Toolkit :: Find Toolbar, defect)
Toolkit
Find Toolbar
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: dholbert, Assigned: mikedeboer)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(3 files)
Suppose you want to look through the instances of the word "grow" in https://www.w3.org/TR/css-flexbox-1/ STR: 1. Visit https://www.w3.org/TR/css-flexbox-1/ 2. Ctrl+F to open findbar. 3. Type "gro". 4. Hit Ctrl+G a few times to skip through the results. (Notice that you're getting hits for "group", which you're not interested in. So, you'll need to continue typing.) 5. Type "w" EXPECTED RESULTS: - Findbar should be left with "grow" - Find-in-page should have jumped to an instance of that word. ACTUAL RESULTS: - Findbar is left with "w", and find-in-page is showing me all the instances of "w". - Specifically, in step 4, my Ctrl+G action caused the findbar contents to be *fully selected* for some reason! - So in step 5, when I type "w", it stomps on the current findbar contents -- it stomps on my partially entered word that I wanted to continue entering. This seems to be a regression, caused by the modal find-in-page feature. If I disable the "findbar.modalHighlight" pref, I get EXPECTED RESULTS.
Reporter | ||
Comment 1•7 years ago
|
||
Reporter | ||
Comment 2•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Attachment #8828984 -
Attachment description: screencast of expected results (with feature preffed off) → screencast of STR & expected results (with feature preffed off)
Reporter | ||
Comment 3•7 years ago
|
||
This has been a particular pain point for me with modal find-in-page, BTW. I perform something like the STR quite frequently when searching through code during my day to day work. I type part of a variable/function name into the findbar, and skip forward through a few hits, and I discover that I need to be more specific, so I continue typing, and then realize that I've now stomped on the partially-entered word due to the fact that the findbar highlighted itself on my first Ctrl+G action. This has been an issue with this new feature for a while, but I haven't gotten around to reporting it (I think) until now. Apologies if it's been previously reported.
Assignee | ||
Comment 4•7 years ago
|
||
Hi Daniel, it has not been reported as of yet, so thanks for that! I will fix it asap.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Comment 5•7 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #4) > Hi Daniel, it has not been reported as of yet, so thanks for that! I will > fix it asap. It was reported as bug 1310797. =/
Assignee | ||
Comment 6•7 years ago
|
||
Hi Nathan, my apologies! It appears that I 'overlooked' that one as it seemed a little less serious at the time compared to the swath of other bugs I was looking into. Would you mind if I dupe your bug to this one as it contains screenshots and other info?
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(nfroyd)
Comment 8•7 years ago
|
||
(In reply to Mike de Boer [:mikedeboer] from comment #6) > Hi Nathan, my apologies! It appears that I 'overlooked' that one as it > seemed a little less serious at the time compared to the swath of other bugs > I was looking into. No problem! > Would you mind if I dupe your bug to this one as it contains screenshots and > other info? Done, thanks!
Flags: needinfo?(nfroyd)
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8829402 [details] Bug 1332757 - don't select the findbar input field contents upon find-again when modal highlighting is enabled. https://reviewboard.mozilla.org/r/106518/#review107784
Attachment #8829402 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 11•7 years ago
|
||
Pushed by mdeboer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d385f49428c2 don't select the findbar input field contents upon find-again when modal highlighting is enabled. r=Gijs
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d385f49428c2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Comment 13•7 years ago
|
||
This was a trunk-only issue, correct?
Flags: needinfo?(mdeboer)
Version: unspecified → Trunk
Reporter | ||
Comment 14•7 years ago
|
||
This is a long-standing issue, but it looks like this feature is only enabled in Nightly for now... https://dxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#648-650 ...so I suspect RyanVM is right - we don't need to worry about other branches (not their default configuration at least).
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(mdeboer)
You need to log in
before you can comment on or make changes to this bug.
Description
•