1332798 - Crash in <name omitted> | mozilla::widget::RectTextureImage::BeginUpdate

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, critical)

Description

[Mats Palmgren (:mats)]

This bug was filed from the Socorro interface and is 
report bp-0b3cb402-547b-40cc-8a02-63ebc2170120.
=============================================================

Looks like a null-pointer crash in RectTextureImage::BeginUpdate:
https://hg.mozilla.org/releases/mozilla-release/annotate/8612c3320053/widget/cocoa/RectTextureImage.mm#l56

The MacIOSurface::CreateIOSurface may return nullptr.

Comment 1

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Bug 1332798 - Add null check after CreateIOSurface.

Review commit: https://reviewboard.mozilla.org/r/106466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106466/

Comment 2

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Yes, submitted a patch to fix this.

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8829348 [details]
Bug 1332798 - Add null check after CreateIOSurface.

https://reviewboard.mozilla.org/r/106466/#review108250

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=51ce4bf4940a7c42abcd5585b401face57eac4cc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b8e2061312f
Add null check after CreateIOSurface. r=mstange

Comment 6

[Wes Kocher (:KWierso)]

https://hg.mozilla.org/mozilla-central/rev/6b8e2061312f

Comment 7

[Ryan VanderMeulen [:RyanVM]]

AFAICT, this crash goes back a ways. Please request Aurora/Beta approval on this patch when you get a chance.

Comment 8

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8829348 [details]
Bug 1332798 - Add null check after CreateIOSurface.

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: Firefox will crash sometimes.
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It just added a null check.
[String changes made/needed]: none

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8829348 [details]
Bug 1332798 - Add null check after CreateIOSurface.

We will take this patch to fix the crash. Aurora53+. And, in the future, please fill the whole uplift request template.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a2ed1e8da84e

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8829348 [details]
Bug 1332798 - Add null check after CreateIOSurface.

crash fix for beta52

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cfa727a93b0b