Crash in <name omitted> | mozilla::widget::RectTextureImage::BeginUpdate

RESOLVED FIXED in Firefox 52

Status

()

Core
Widget: Cocoa
--
critical
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mats, Assigned: mtseng)

Tracking

({crash})

unspecified
mozilla54
Unspecified
Mac OS X
crash
Points:
---

Firefox Tracking Flags

(firefox51 wontfix, firefox52 fixed, firefox53 fixed, firefox54 fixed)

Details

(crash signature)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

a year ago
This bug was filed from the Socorro interface and is 
report bp-0b3cb402-547b-40cc-8a02-63ebc2170120.
=============================================================

Looks like a null-pointer crash in RectTextureImage::BeginUpdate:
https://hg.mozilla.org/releases/mozilla-release/annotate/8612c3320053/widget/cocoa/RectTextureImage.mm#l56

The MacIOSurface::CreateIOSurface may return nullptr.
(Reporter)

Updated

a year ago
Flags: needinfo?(mtseng)
Comment hidden (mozreview-request)
Yes, submitted a patch to fix this.
Assignee: nobody → mtseng
Flags: needinfo?(mtseng)

Comment 3

a year ago
mozreview-review
Comment on attachment 8829348 [details]
Bug 1332798 - Add null check after CreateIOSurface.

https://reviewboard.mozilla.org/r/106466/#review108250
Attachment #8829348 - Flags: review?(mstange) → review+

Comment 5

a year ago
Pushed by mtseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b8e2061312f
Add null check after CreateIOSurface. r=mstange

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6b8e2061312f
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
AFAICT, this crash goes back a ways. Please request Aurora/Beta approval on this patch when you get a chance.
status-firefox51: --- → wontfix
status-firefox52: --- → affected
status-firefox53: --- → affected
Flags: needinfo?(mtseng)
Comment on attachment 8829348 [details]
Bug 1332798 - Add null check after CreateIOSurface.

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: Firefox will crash sometimes.
[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It just added a null check.
[String changes made/needed]: none
Flags: needinfo?(mtseng)
Attachment #8829348 - Flags: approval-mozilla-beta?
Attachment #8829348 - Flags: approval-mozilla-aurora?
Comment on attachment 8829348 [details]
Bug 1332798 - Add null check after CreateIOSurface.

We will take this patch to fix the crash. Aurora53+. And, in the future, please fill the whole uplift request template.
Attachment #8829348 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 10

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/a2ed1e8da84e
status-firefox53: affected → fixed
Comment on attachment 8829348 [details]
Bug 1332798 - Add null check after CreateIOSurface.

crash fix for beta52
Attachment #8829348 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 12

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/cfa727a93b0b
status-firefox52: affected → fixed
You need to log in before you can comment on or make changes to this bug.