1332886 - Kumascript error when rendering non-ASCII URLs

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: General, defect, P5)

Description

[cswcsy]

:: Developer Documentation Request

      Request Type: Correction
     Gecko Version: unspecified
 Technical Contact: 

:: Details

https://developer.mozilla.org/ko/docs/Web/SVG/Tutorial/%EC%9C%84%EC%B9%98

occur error but i don't know why

Comment 2

[John Whitlock [:jwhitlock]]

I can confirm this is an issue in my developer environment.

On our rendering server, we recently upgraded from node v0.10 to v6, and upgraded some 3rd party libraries as well.  It appears that rendering pages with non-ASCII titles were affected.

The rendering server is making this request for the page source:

GET /en-US/docs/ko/Web/SVG/Tutorial/ܑX0?raw=1

The correct request would be:

GET /en-US/docs/ko/Web/SVG/Tutorial/ܑ%EC%9C%84%EC%B9%98?raw=1

Comment 3

[Florian Scholz (Open Web Docs)]

More examples of this (again non-ASCII slugs):
https://developer.mozilla.org/fr/docs/Web/JavaScript/H%C3%A9ritage_et_cha%C3%AEne_de_prototypes
https://developer.mozilla.org/fr/docs/Web/JavaScript/Une_r%C3%A9introduction_%C3%A0_JavaScript

Comment 4

[Ryan Johnson (:rjohnson)]

The proposed fix has been merged to master: https://github.com/mozilla/kumascript/commit/264935a36b2bf0fb452a69bddfbd58c143cbbb58

It seems that this was due to a change in the "express" node package, specifically its "req.params" property. In the past, the values of this property must have been taken as-is from the incoming URL (so left escaped), but now they are un-escaped, leading to a bad raw document URL for Kuma.

Comment 5

[Ryan Johnson (:rjohnson)]

My fix was bad. By using querystring.escape, I was also url-encoding/escaping the slashes within the doc path. Changed to use encodeURI instead.

https://github.com/mozilla/kumascript/pull/98

Comment 6

[Florian Scholz (Open Web Docs)]

Thanks Ryan! Latest master works great for me in my local environment.

Comment 7

[John Whitlock [:jwhitlock]]

A further change was needed in the deployment scripts to get the rendering engine to use the latest code:

https://github.com/mozilla/kuma/pull/4106

The fix has been deployed to staging and production, and the three URLs render without error:

https://developer.mozilla.org/ko/docs/Web/SVG/Tutorial/%EC%9C%84%EC%B9%98
https://developer.mozilla.org/fr/docs/Web/JavaScript/H%C3%A9ritage_et_cha%C3%AEne_de_prototypes
https://developer.mozilla.org/fr/docs/Web/JavaScript/Une_r%C3%A9introduction_%C3%A0_JavaScript