Deprecation warning from mimeJSComponents.js:443 still present after bug 1324443

RESOLVED FIXED in Thunderbird 54.0

Status

MailNews Core
MIME
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: Jorg K (GMT+2), Assigned: Jorg K (GMT+2))

Tracking

Trunk
Thunderbird 54.0

Thunderbird Tracking Flags

(thunderbird52 fixed, thunderbird53 fixed, thunderbird54 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
+++ This bug was initially created as a clone of Bug #1324443 +++
https://hg.mozilla.org/comm-central/rev/9c1291d2e1f7521c2558e8c76f37a6b724c9be32#l1.12

When I send an e-mail with me as the sender and charset wind-1252, the From gets encoded as:
From: =?UTF-8?Q?J=c3=b6rg_Knobloch?= <jorgk@jorgk.com>

Yet I get a complaint on the intent to encode the From header with the charset of the message.

Since encodeMimePartIIStr_UTF8 just ignores the charset passed in, it makes no sense to call it with a charset it will just ignore:
https://dxr.mozilla.org/comm-central/rev/9cb95ca4c3f7cbd473e78addb8e3607af6af8386/mailnews/mime/src/mimeJSComponents.js#442

This message is unnecessary and will scare people.

Besides, according to RFC 6532 headers can have raw UTF-8 but nothing else (https://tools.ietf.org/html/rfc6532#section-3.2).

Patch coming.
(Assignee)

Comment 1

4 months ago
Created attachment 8829336 [details] [diff] [review]
1332997-deprecation-warning.patch
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8829336 - Flags: review?(acelists)

Updated

4 months ago
Attachment #8829336 - Flags: review?(acelists) → review+
https://hg.mozilla.org/comm-central/rev/4d39e74d202ec52babe230464670bea8c33ea042
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 54.0
(Assignee)

Comment 3

4 months ago
Comment on attachment 8829336 [details] [diff] [review]
1332997-deprecation-warning.patch

This ugly warning should also go from the other branches.
Attachment #8829336 - Flags: approval-comm-beta+
Attachment #8829336 - Flags: approval-comm-aurora+
(Assignee)

Comment 4

4 months ago
Aurora (TB 53):
https://hg.mozilla.org/releases/comm-aurora/rev/0a3a0a1fad09404c2810f1c1a9b05ee3b72c452c
status-thunderbird52: --- → affected
status-thunderbird53: --- → fixed
status-thunderbird54: --- → fixed
(Assignee)

Comment 5

4 months ago
Beta (TB 52):
https://hg.mozilla.org/releases/comm-beta/rev/32e89445bd829a162180193ae4792f750085c50a
status-thunderbird52: affected → fixed
You need to log in before you can comment on or make changes to this bug.