1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

if observerService is NULL, we will crash

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp

Review commit: https://reviewboard.mozilla.org/r/106470/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106470/

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8829349 [details]
Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp

https://reviewboard.mozilla.org/r/106470/#review107426

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72fba5033e0c
Fix a misleading indentation in PeerConnectionCtx.cpp r=drno

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8829349 [details]
Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp

https://reviewboard.mozilla.org/r/106470/#review107470

THough nils already r+'d... this is why we have the rule about bracing.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/72fba5033e0c

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Let's uplift this.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8829349 [details]
Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp

Approval Request Comment
[Feature/Bug causing the regression]: bug 1318180
[User impact if declined]: if observerService is NULL, we will crash
[Is this code covered by automated tests?]: No clue
[Has the fix been verified in Nightly?]: Don't know how to reproduce as it is pure coding issue
[Needs manual test from QE? If yes, steps to reproduce]:  No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Less than keeping it in the code. This is an obvious programming mistake
[Why is the change risky/not risky?]: We will be in a better place with the patch because we are avoiding a call on a null object.
[String changes made/needed]: Non

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8829349 [details]
Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp

crash fix, aurora53+, beta52+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

AFAICT, Beta52 isn't affected?

Comment 10

[Nils Ohlmeier [:drno]]

Ryan you are right. This only affects 53, because that is where I landed bug 1318180.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ad823ff1774b