Fix a misleading indentation in PeerConnectionCtx.cpp

RESOLVED FIXED in Firefox 53

Status

()

Product:
Core
Component:
WebRTC: Signaling
RESOLVED FIXED
Reported:
a year ago
Modified:
a year ago

People

(Reporter: sylvestre, Assigned: sylvestre)

Tracking

(Blocks: 1 bug, {coverity})

Version:
Trunk
Target:
mozilla54
Keywords:
coverity
Points:
---

Firefox Tracking Flags

(firefox51 unaffected, firefox52 unaffected, firefox53 fixed, firefox54 fixed)

Details

(Whiteboard: [CID 1398285])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp
59 bytes, text/x-review-board-request
jesup
: review+
drno
: review+
jcristau
: approval-mozilla-aurora+
Details | Review
(Assignee)

Description

•
a year ago 
if observerService is NULL, we will crash
Comment hidden (mozreview-request)

Comment 2

•
a year ago
mozreview-review 
Comment on attachment 8829349 [details]
Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp

https://reviewboard.mozilla.org/r/106470/#review107426
Attachment #8829349 - Flags: review+

Comment 3

•
a year ago 
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72fba5033e0c
Fix a misleading indentation in PeerConnectionCtx.cpp r=drno
 (Assignee)

Updated

•
a year ago
Assignee: nobody → sledru

Comment 4

•
a year ago
mozreview-review 
Comment on attachment 8829349 [details]
Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp

https://reviewboard.mozilla.org/r/106470/#review107470

THough nils already r+'d... this is why we have the rule about bracing.
Attachment #8829349 - Flags: review?(rjesup) → review+

Comment 5

•
a year ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/72fba5033e0c
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

Comment 6

•
a year ago 
Let's uplift this.
Flags: needinfo?(drno)
 (Assignee)

Comment 7

•
a year ago 
Comment on attachment 8829349 [details]
Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp

Approval Request Comment
[Feature/Bug causing the regression]: bug 1318180
[User impact if declined]: if observerService is NULL, we will crash
[Is this code covered by automated tests?]: No clue
[Has the fix been verified in Nightly?]: Don't know how to reproduce as it is pure coding issue
[Needs manual test from QE? If yes, steps to reproduce]:  No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Less than keeping it in the code. This is an obvious programming mistake
[Why is the change risky/not risky?]: We will be in a better place with the patch because we are avoiding a call on a null object.
[String changes made/needed]: Non
Attachment #8829349 - Flags: approval-mozilla-beta?
Attachment #8829349 - Flags: approval-mozilla-aurora?

Comment 8

•
a year ago 
Comment on attachment 8829349 [details]
Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp

crash fix, aurora53+, beta52+
Attachment #8829349 - Flags: approval-mozilla-beta?
Attachment #8829349 - Flags: approval-mozilla-beta+
Attachment #8829349 - Flags: approval-mozilla-aurora?
Attachment #8829349 - Flags: approval-mozilla-aurora+
Flags: needinfo?(drno)

Comment 9

•
a year ago 
AFAICT, Beta52 isn't affected?
Flags: needinfo?(sledru)

Comment 10

•
a year ago 
Ryan you are right. This only affects 53, because that is where I landed bug 1318180.
status-firefox51: --- → unaffected
status-firefox52: --- → unaffected

Comment 11

•
a year ago
bugherderuplift 
https://hg.mozilla.org/releases/mozilla-aurora/rev/ad823ff1774b
status-firefox53: affected → fixed
Attachment #8829349 - Flags: approval-mozilla-beta+
 (Assignee)

Updated

•
a year ago
Flags: needinfo?(sledru)
You need to log in before you can comment on or make changes to this bug.