Closed
Bug 1333002
Opened 6 years ago
Closed 6 years ago
Fix a misleading indentation in PeerConnectionCtx.cpp
Categories
(Core :: WebRTC: Signaling, defect)
Core
WebRTC: Signaling
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox51 | --- | unaffected |
firefox52 | --- | unaffected |
firefox53 | --- | fixed |
firefox54 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1398285])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
jesup
:
review+
drno
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details |
if observerService is NULL, we will crash
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8829349 [details] Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp https://reviewboard.mozilla.org/r/106470/#review107426
Attachment #8829349 -
Flags: review+
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/72fba5033e0c Fix a misleading indentation in PeerConnectionCtx.cpp r=drno
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sledru
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8829349 [details] Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp https://reviewboard.mozilla.org/r/106470/#review107470 THough nils already r+'d... this is why we have the rule about bracing.
Attachment #8829349 -
Flags: review?(rjesup) → review+
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/72fba5033e0c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 8829349 [details] Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp Approval Request Comment [Feature/Bug causing the regression]: bug 1318180 [User impact if declined]: if observerService is NULL, we will crash [Is this code covered by automated tests?]: No clue [Has the fix been verified in Nightly?]: Don't know how to reproduce as it is pure coding issue [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: Less than keeping it in the code. This is an obvious programming mistake [Why is the change risky/not risky?]: We will be in a better place with the patch because we are avoiding a call on a null object. [String changes made/needed]: Non
Attachment #8829349 -
Flags: approval-mozilla-beta?
Attachment #8829349 -
Flags: approval-mozilla-aurora?
Comment 8•6 years ago
|
||
Comment on attachment 8829349 [details] Bug 1333002 - Fix a misleading indentation in PeerConnectionCtx.cpp crash fix, aurora53+, beta52+
Attachment #8829349 -
Flags: approval-mozilla-beta?
Attachment #8829349 -
Flags: approval-mozilla-beta+
Attachment #8829349 -
Flags: approval-mozilla-aurora?
Attachment #8829349 -
Flags: approval-mozilla-aurora+
Updated•6 years ago
|
Flags: needinfo?(drno)
Comment 10•6 years ago
|
||
Ryan you are right. This only affects 53, because that is where I landed bug 1318180.
Updated•6 years ago
|
status-firefox51:
--- → unaffected
status-firefox52:
--- → unaffected
Comment 11•6 years ago
|
||
bugherderuplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/ad823ff1774b
Updated•6 years ago
|
Attachment #8829349 -
Flags: approval-mozilla-beta+
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(sledru)
You need to log in
before you can comment on or make changes to this bug.
Description
•