1333009 - Page Shot icon is no longer displayed in toolbar after install, on latest Nightly version (Build ID: 20170122030212)

Status: VERIFIED FIXED

(Core Graveyard :: Identity, defect)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

[Affected versions]:
- Nightly 53.0a1 (Build ID: 20170122030212)
- Mozilla Page Shot 4.3.201701052116

[Affected Platforms]:
- All Windows
- All Mac
- All Linux

[Prerequisites]:
- Test Pilot add-on was previously installed on the profile.

[Steps to reproduce]:
1. Open Firefox with the profile from prerequisites and navigate to testpilot.firefox.com page.
2. Click on the Page Shot experiment card and enabled it.
3. Observe the browser toolbar.

[Expected result]:
- The Page Shot icon is displayed in browser toolbar.

[Actual result]:
- The Page Shot icon is not displayed in browser toolbar even if add-on appears to be installed.

[Regression]:
- Looks like the following bug has the changes which introduced the regression:https://bugzilla.mozilla.org/show_bug.cgi?id=1330821

- Last good revision: 645331fa032779e6324e32a11898a55e6c75ee24
- First bad revision: ece477bc26a761831519a9ad9893c504dcd14f03
- Pushlog: https://goo.gl/4AkYMx

[Notes]:
- Here is a screen recording with the issue: https://goo.gl/594qBO.

Comment 1

[Florian Quèze [:florian]]

Following these steps to reproduce, I get the following in my terminal:

console.error: 
Object
    - message = Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
    - fileName = undefined
    - lineNumber = 8
    - stack = @undefined:8:NaN|@resource://jid1-neeaf3sahdkhpa-at-jetpack/lib/user.js:8:1|@resource://jid1-neeaf3sahdkhpa-at-jetpack/lib/req.js:2:12|@resource://jid1-neeaf3sahdkhpa-at-jetpack/lib/shooter.js:12:1|@resource://jid1-neeaf3sahdkhpa-at-jetpack/lib/main.js:14:15|run@resource://gre/modules/commonjs/sdk/addon/runner.js:147:19|startup/</<@resource://gre/modules/commonjs/sdk/addon/runner.js:87:9|process@resource://gre/modules/Promise-backend.js:917:23|walkerLoop@resource://gre/modules/Promise-backend.js:801:7|Promise*scheduleWalkerLoop@resource://gre/modules/Promise-backend.js:734:11|schedulePromise@resource://gre/modules/Promise-backend.js:765:7|completePromise@resource://gre/modules/Promise-backend.js:702:7|handler@resource://gre/modules/commonjs/sdk/addon/window.js:56:3|EventListener.handleEvent*@resource://gre/modules/commonjs/sdk/addon/window.js:54:1|startup/<@resource://gre/modules/commonjs/sdk/addon/runner.js:72:21|process@resource://gre/modules/Promise-backend.js:917:23|walkerLoop@resource://gre/modules/Promise-backend.js:801:7|Promise*scheduleWalkerLoop@resource://gre/modules/Promise-backend.js:734:11|schedulePromise@resource://gre/modules/Promise-backend.js:765:7|completePromise@resource://gre/modules/Promise-backend.js:702:7|readURI/<@resource://gre/modules/commonjs/sdk/net/url.js:50:9|onStopRequest@resource://gre/modules/NetUtil.jsm:128:17|
    - toString = () => toString


Line 8 in that user.js file is:
Cu.import("resource://gre/modules/FxAccountsOAuthClient.jsm", {}),FxAccountsOAuthClient = _Cu$import.FxAccountsOAuthClient;var _Cu$import2 =

Comment 2

[Florian Quèze [:florian]]

Is https://github.com/mozilla-services/pageshot/blob/master/addon/lib/user.js actually using FxAccountsOAuthClient.jsm for something or is this just dead code? How much effort is it to update this file?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

If it is used, we should have Page Shot ship this file.

Comment 4

[Donovan Preston [:fzzzy]]

It's dead code. We'd probably like to add Firefox Accounts support back to Page Shot at some point, but we'd likely do the oauth login in content instead of chrome if we did.

Comment 5

[Ian Bicking (:ianbicking)]

Version 5.1.0 fixes this.  It is currently deployed to https://pageshot.stage.mozaws.net/homepage/install-test-local.html

This is version is due for general release this week.

Comment 6

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I'm cleaning up the old issues. The Page Shot add-on is no longer supported, but he issue was fixed and verified on the latest version of Page Shot when it was in development. Considering this I will also mark this bug as verified fixed.