1333011 - wasm: Tweak memory / data section check (and a few spec tests tweaks)

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Comment 1

[Benjamin Bouvier [:bbouvier]]

Attachment: 1.assert-exhaustion.patch

Very simple patch: implement `assert_exhaustion` in wast.js and reimport the tests that use it.

Comment 2

[Benjamin Bouvier [:bbouvier]]

Attachment: 2.update-spectests.patch

Other spec tests that Just Pass.

Comment 3

[Benjamin Bouvier [:bbouvier]]

Attachment: 3.zero-seg-validation.patch

This tweaks segments size checking for 0-sized segments (counterpart to https://github.com/WebAssembly/design/issues/897 and https://github.com/WebAssembly/spec/pull/399 )

Comment 4

[Benjamin Bouvier [:bbouvier]]

Attachment: 4.moar-tests.patch

These are the tests in https://github.com/WebAssembly/spec/pull/408, which should be merged soon.

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 8829410 [details] [diff] [review]
3.zero-seg-validation.patch

Review of attachment 8829410 [details] [diff] [review]:
-----------------------------------------------------------------

Ah good; I liked it better this way.

Comment 6

[Luke Wagner [:luke]]

Comment on attachment 8829411 [details] [diff] [review]
4.moar-tests.patch

Review of attachment 8829411 [details] [diff] [review]:
-----------------------------------------------------------------

Nice to see we're already passing all these.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b9cb8e74d7d
Implement assert_exhaustion in the wast interpreter and reimport tests that use it; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/5988b2c740a4
Update wasm spec import script and reimports a few tests; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc1db518e229
wasm: tweak segment validation for zero-sized segments; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/7de92df12048
wasm: add spec tests for checking segments against actual sizes; r=luke

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2b9cb8e74d7d
https://hg.mozilla.org/mozilla-central/rev/5988b2c740a4
https://hg.mozilla.org/mozilla-central/rev/dc1db518e229
https://hg.mozilla.org/mozilla-central/rev/7de92df12048