Closed Bug 1333011 Opened 5 years ago Closed 5 years ago

wasm: Tweak memory / data section check (and a few spec tests tweaks)

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox53 --- affected
firefox54 --- fixed

People

(Reporter: bbouvier, Assigned: bbouvier)

References

Details

Attachments

(4 files)

No description provided.
Very simple patch: implement `assert_exhaustion` in wast.js and reimport the tests that use it.
Attachment #8829408 - Flags: review?(luke)
Other spec tests that Just Pass.
Attachment #8829409 - Flags: review?(luke)
This tweaks segments size checking for 0-sized segments (counterpart to https://github.com/WebAssembly/design/issues/897 and https://github.com/WebAssembly/spec/pull/399 )
Attachment #8829410 - Flags: review?(luke)
These are the tests in https://github.com/WebAssembly/spec/pull/408, which should be merged soon.
Attachment #8829411 - Flags: review?(luke)
Attachment #8829408 - Flags: review?(luke) → review+
Attachment #8829409 - Flags: review?(luke) → review+
Comment on attachment 8829410 [details] [diff] [review]
3.zero-seg-validation.patch

Review of attachment 8829410 [details] [diff] [review]:
-----------------------------------------------------------------

Ah good; I liked it better this way.
Attachment #8829410 - Flags: review?(luke) → review+
Comment on attachment 8829411 [details] [diff] [review]
4.moar-tests.patch

Review of attachment 8829411 [details] [diff] [review]:
-----------------------------------------------------------------

Nice to see we're already passing all these.
Attachment #8829411 - Flags: review?(luke) → review+
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b9cb8e74d7d
Implement assert_exhaustion in the wast interpreter and reimport tests that use it; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/5988b2c740a4
Update wasm spec import script and reimports a few tests; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc1db518e229
wasm: tweak segment validation for zero-sized segments; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/7de92df12048
wasm: add spec tests for checking segments against actual sizes; r=luke
You need to log in before you can comment on or make changes to this bug.