1333036 - configure script should check whether paths provided from --with-{libclang,clang}-path are valid

Status: RESOLVED DUPLICATE of bug 1363655

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

See bug 1302028 comment 73. Currently, the document of those two options are not clear enough that --with-libclang-path should be specified with the path of the directory which contains libclang.{so,dll}, while --with-clang-path should be specified with the path of the clang{,.exe} executable itself.

The document should be improved, but it is more helpful to have the configure script check the path passed in and see whether they are valid (contains the desired file).

It should be as easy as checking whether $LIBCLANG_PATH/libclang.{so,dll} exists, and whether $CLANG_PATH is an existing file whose name is clang or clang.exe.

Comment 1

[Chris Peterson [:cpeterson]]

Nathan, can you take a look at Xidorn's configure suggestion here? Should this be fixed in your mach bootstrap work in bug 1314355?

Comment 2

[Nathan Froyd [:froydnj]]

(In reply to Chris Peterson [:cpeterson] from comment #1)
> Nathan, can you take a look at Xidorn's configure suggestion here? Should
> this be fixed in your mach bootstrap work in bug 1314355?

This can be fixed separately from the mach bootstrap work.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Xidorn Quan [:xidorn] UTC+10 (less responsive 15/Apr-3/May) from comment #0)
> It should be as easy as checking whether $LIBCLANG_PATH/libclang.{so,dll}
> exists, and whether $CLANG_PATH is an existing file whose name is clang or
> clang.exe.

It's not this easy, since $CLANG_PATH might be /path/to/clang-3.9 or somesuch.  Maybe we can make the check more stringent if people are guaranteed to be using our tooltool binaries, but we're not to that point yet, even if could make bootstrap download those binaries.

Comment 4

[Chris Peterson [:cpeterson]]

I spoke with Nathan and he says this bug is a duplicate of bug 1363655 ("configure should fail when libclang is not there").