Closed Bug 1333036 Opened 7 years ago Closed 7 years ago

configure script should check whether paths provided from --with-{libclang,clang}-path are valid

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1363655
Tracking Status
firefox53 --- affected

People

(Reporter: xidorn, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Stylo])

See bug 1302028 comment 73. Currently, the document of those two options are not clear enough that --with-libclang-path should be specified with the path of the directory which contains libclang.{so,dll}, while --with-clang-path should be specified with the path of the clang{,.exe} executable itself.

The document should be improved, but it is more helpful to have the configure script check the path passed in and see whether they are valid (contains the desired file).

It should be as easy as checking whether $LIBCLANG_PATH/libclang.{so,dll} exists, and whether $CLANG_PATH is an existing file whose name is clang or clang.exe.
Nathan, can you take a look at Xidorn's configure suggestion here? Should this be fixed in your mach bootstrap work in bug 1314355?
Blocks: 1314355
Flags: needinfo?(nfroyd)
(In reply to Chris Peterson [:cpeterson] from comment #1)
> Nathan, can you take a look at Xidorn's configure suggestion here? Should
> this be fixed in your mach bootstrap work in bug 1314355?

This can be fixed separately from the mach bootstrap work.
Flags: needinfo?(nfroyd)
Summary: stylo: configure script should check whether paths provided from --with-{libclang,clang}-path are valid → configure script should check whether paths provided from --with-{libclang,clang}-path are valid
Whiteboard: [Stylo]
(In reply to Xidorn Quan [:xidorn] UTC+10 (less responsive 15/Apr-3/May) from comment #0)
> It should be as easy as checking whether $LIBCLANG_PATH/libclang.{so,dll}
> exists, and whether $CLANG_PATH is an existing file whose name is clang or
> clang.exe.

It's not this easy, since $CLANG_PATH might be /path/to/clang-3.9 or somesuch.  Maybe we can make the check more stringent if people are guaranteed to be using our tooltool binaries, but we're not to that point yet, even if could make bootstrap download those binaries.
I spoke with Nathan and he says this bug is a duplicate of bug 1363655 ("configure should fail when libclang is not there").
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.