1333046 - Teach the tab object how to zombify/unzombify itself

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan Henning [:JanH]]

External consumers outside browser.js that get hold of a tab object still have to load the MemoryObserver themselves in order to zombify a tab - we should either move the implementation of that function into the tab prototype, or at least include a forwarding function for easier calling.

Restoring a zombified tab is even worse - this is done by the session store which doesn't export this capability at all, so anybody else wanting to restore a tab must poke around within the session store data structures and reimplement the whole process, which means either duplicating quite a lot of session store code, or else potentially loosing data [1].

[1] E.g. this add-on: https://github.com/jmozmoz/tabPreLoader/issues/1

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1333046 - Part 1 - Expose a method to restore delay-loaded tabs via the tab object.

Actors outside of the session store shouldn't have to poke around within the session store's data structure and end up reimplementing parts of the session store code (and cause data loss if the implementation is incomplete) in order to restore delay loaded zombie tabs. Therefore, we simply expose a method for this via BrowserApp's tab object.

To simplify handling and make the method a little more fool-proof for external callers, the check whether the tab is actually zombified is moved into the restoreZombieTab() function.

Later on, we can also hook up this method to the appropriate web extension API (see bug 1322485).

Review commit: https://reviewboard.mozilla.org/r/107234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107234/

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1333046 - Part 2 - Move zombification function into the tab object.

A tab object should know how to zombify itself instead of having to rely on the MemoryObserver. This also simplifies the situation for anybody else who wants to call this function since it is no longer necessary to figure out how to load the MemoryObserver for this.

Review commit: https://reviewboard.mozilla.org/r/107236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107236/

Comment 3

[Andrzej Hunt :ahunt]

Comment on attachment 8830477 [details]
Bug 1333046 - Part 1 - Expose a method to restore delay-loaded tabs via the tab object.

https://reviewboard.mozilla.org/r/107234/#review108424

Comment 4

[Andrzej Hunt :ahunt]

Comment on attachment 8830478 [details]
Bug 1333046 - Part 2 - Move zombification function into the tab object.

https://reviewboard.mozilla.org/r/107236/#review108426

This looks like a good improvement!

Comment 5

[Jan Henning [:JanH]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e72c2383918e6545bc8670d1bf29fc964f3c621

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11ba6139302e
Part 1 - Expose a method to restore delay-loaded tabs via the tab object. r=ahunt
https://hg.mozilla.org/integration/autoland/rev/2bd13e9c2a01
Part 2 - Move zombification function into the tab object. r=ahunt

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/11ba6139302e
https://hg.mozilla.org/mozilla-central/rev/2bd13e9c2a01