1333075 - [Captive Portal] Captive Portal Notification bar is not added to all opened windows

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Adrian Florinescu [:aflorinescu]]

following up for https://bugzilla.mozilla.org/show_bug.cgi?id=1313568#c56

[Affected versions]:
Firefox Nightly 53.0a1 (2017-01-23)

[Tested on]:
Windows 10

[Steps to reproduce]:
1. Open Firefox. (if no internet connection is available CP will not work due to bug 1332271)
2. Open multiple windows and minimize all.
3. Disconnect all internet connections and enable Captive Portal Wi-fi.
4. Restore all FF windows, one by one.

[Actual Result]:
Only the first restored FF window will present Captive Portal notification bar, the rest will not.
All new windows open after Wi-fi is enabled will present Captive Portal notification bar.

[Expected Result]:
All FF windows shall present the Captive Portal Notification bar.

Comment 1

[Adrian Florinescu [:aflorinescu]]

[Tracking Requested - why for this release]: spin off from bug 1313568

Comment 2

[Julien Cristau [:jcristau]]

Track captive portal issue for 52.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1333075 - Ensure captive portal notification is displayed in all windows after portal is detected when none have focus.

Review commit: https://reviewboard.mozilla.org/r/106846/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106846/

Comment 4

[Matthew N. [:MattN]]

Comment on attachment 8829889 [details]
Bug 1333075 - Ensure captive portal notification is displayed in all windows after portal is detected when none have focus.

https://reviewboard.mozilla.org/r/106846/#review108024

Thanks for adding a test

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31527a33fecf
Ensure captive portal notification is displayed in all windows after portal is detected when none have focus. r=MattN

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/31527a33fecf

Comment 7

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8829889 [details]
Bug 1333075 - Ensure captive portal notification is displayed in all windows after portal is detected when none have focus.

Approval Request Comment
[Feature/Bug causing the regression]: Captive Portal: follow-up to bug 1313568
[User impact if declined]: Captive portal notification won't be shown in all windows if portal is detected when Firefox doesn't have focus.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Tested locally, green try push.
[Needs manual test from QE? If yes, steps to reproduce]: Yes. STR is in comment 0
[List of other uplifts needed for the feature/fix]: bug 1313568
[Is the change risky?]: No
[Why is the change risky/not risky?]: This patch simply ensures we show a notification immediately after detection and is covered by tests.
[String changes made/needed]: None.

Comment 8

[Gerry Chang [:gchang]]

Hi Adrian,
could you help verify if this issue is fixed as expected on a latest Nightly build? Thanks!

Comment 9

[Adrian Florinescu [:aflorinescu]]

Verified fix on 54.0a1/20170125110119 on Ubuntu 16.04, Windows10 and Mac OSX 10.12.

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8829889 [details]
Bug 1333075 - Ensure captive portal notification is displayed in all windows after portal is detected when none have focus.

show captive portal notification on all windows, aurora53+, beta52+

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/55d70a7681c3

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for Beta uplift.

Comment 13

[(inactive) Nihanth Subramanya [:nhnt11]]

The patch applies fine on top of attachment 8832163 [details] [diff] [review] in bug 1313568 (which should be uplifted first).

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c2d975acbc83

Comment 15

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Windows 10 x64, Mac OS X 10.11 and Ubuntu 14.04 x64 using Firefox 52 Beta 9 (buildID: 20170223185858) and latest Aurora 53.0a2 (2017-02-24).