Closed Bug 1333122 Opened 3 years ago Closed 3 years ago

Allow WR widgets to coexist with non-WR widgets (part 2)

Categories

(Core :: Graphics: WebRender, defect, P3)

Product:
Core
Component:
Graphics: WebRender
Version:
53 Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox53 --- affected

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(5 files)

Bug 1333122 - Use the CompositorOptions to determine the appropriate LayerManager to create for content-process tabs.
59 bytes, text/x-review-board-request
dvander
: review+
Details
Bug 1333122 - Remove some uses of gfxPrefs::WebRenderEnabled from gfx code.
59 bytes, text/x-review-board-request
sotaro
: review+
Details
Bug 1333122 - Start and stop the RenderThread in any webrender-enabled builds.
59 bytes, text/x-review-board-request
nical
: review+
Details
Bug 1333122 - Remove gfxPrefs::WebRenderEnabled() to avoid it being used inappopriately; do WR and APZ decision-making during compositor creation.
59 bytes, text/x-review-board-request
dvander
: review+
Details
Bug 1333122 - Condition disabling of buffer-rotation on the layer tree rather than a compile-time flag.
59 bytes, text/x-review-board-request
ethlin
: review+
Details 
+++ This bug was initially created as a clone of Bug #1326421 +++

Right now we have the compile-time webrender flag and guards (#ifdef MOZ_ENABLE_WEBRENDER) and the runtime pref (gfx.webrender.enabled). However we will probably need this to be even more granular, and allow individual widgets to have webrender while other widgets are non-webrender. This will allow, for example, doing printing and/or tooltips without webrender while main content windows do have webrender.
Assignee: nobody → bugmail
(dvander, you already reviewed most of part 1 in bug 1326421 but there's a nontrivial test change now so I figured it was better to get a re-review).
Comment on attachment 8829558 [details]
Bug 1333122 - Remove some uses of gfxPrefs::WebRenderEnabled from gfx code.

https://reviewboard.mozilla.org/r/106612/#review107630
Attachment #8829558 - Flags: review?(sotaro.ikeda.g) → review+
Comment on attachment 8829557 [details]
Bug 1333122 - Use the CompositorOptions to determine the appropriate LayerManager to create for content-process tabs.

https://reviewboard.mozilla.org/r/106610/#review107632
Attachment #8829557 - Flags: review?(dvander) → review+
Shoot, I lost a hunk during rebasing. New patches coming.
(The missing hunk had already been reviewed by dvander in bug 1326421 so I guess I can just carry the r+ for that)
Comment on attachment 8829559 [details]
Bug 1333122 - Start and stop the RenderThread in any webrender-enabled builds.

https://reviewboard.mozilla.org/r/106614/#review107634
Attachment #8829559 - Flags: review?(nical.bugzilla) → review+
Comment on attachment 8829561 [details]
Bug 1333122 - Condition disabling of buffer-rotation on the layer tree rather than a compile-time flag.

https://reviewboard.mozilla.org/r/106618/#review107724
Attachment #8829561 - Flags: review?(ethlin) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/b7619d5557e0
Use the CompositorOptions to determine the appropriate LayerManager to create for content-process tabs. r=dvander
https://hg.mozilla.org/projects/graphics/rev/5facc8050cc1
Remove some uses of gfxPrefs::WebRenderEnabled from gfx code. r=sotaro
https://hg.mozilla.org/projects/graphics/rev/e71e873893d9
Start and stop the RenderThread in any webrender-enabled builds. r=nical
https://hg.mozilla.org/projects/graphics/rev/e9d5bf60fd9f
Remove gfxPrefs::WebRenderEnabled() to avoid it being used inappopriately; do WR and APZ decision-making during compositor creation. r=dvander?
https://hg.mozilla.org/projects/graphics/rev/6c0b2aee8144
Condition disabling of buffer-rotation on the layer tree rather than a compile-time flag. r=ethlin
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Comment on attachment 8829560 [details]
Bug 1333122 - Remove gfxPrefs::WebRenderEnabled() to avoid it being used inappopriately; do WR and APZ decision-making during compositor creation.

https://reviewboard.mozilla.org/r/106616/#review108844
Attachment #8829560 - Flags: review?(dvander) → review+
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.