1333122 - Allow WR widgets to coexist with non-WR widgets (part 2)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

+++ This bug was initially created as a clone of Bug #1326421 +++

Right now we have the compile-time webrender flag and guards (#ifdef MOZ_ENABLE_WEBRENDER) and the runtime pref (gfx.webrender.enabled). However we will probably need this to be even more granular, and allow individual widgets to have webrender while other widgets are non-webrender. This will allow, for example, doing printing and/or tooltips without webrender while main content windows do have webrender.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5655791ae20668b483c4facd38ff4e1339a8c161

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1333122 - Use the CompositorOptions to determine the appropriate LayerManager to create for content-process tabs.

Review commit: https://reviewboard.mozilla.org/r/106610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106610/

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1333122 - Remove some uses of gfxPrefs::WebRenderEnabled from gfx code.

Review commit: https://reviewboard.mozilla.org/r/106612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106612/

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1333122 - Start and stop the RenderThread in any webrender-enabled builds.

Review commit: https://reviewboard.mozilla.org/r/106614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106614/

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1333122 - Remove gfxPrefs::WebRenderEnabled() to avoid it being used inappopriately; do WR and APZ decision-making during compositor creation.

Review commit: https://reviewboard.mozilla.org/r/106616/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106616/

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1333122 - Condition disabling of buffer-rotation on the layer tree rather than a compile-time flag.

Review commit: https://reviewboard.mozilla.org/r/106618/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106618/

Comment 7

[Kartikaya Gupta (email:[e-mail])]

(dvander, you already reviewed most of part 1 in bug 1326421 but there's a nontrivial test change now so I figured it was better to get a re-review).

Comment 8

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8829558 [details]
Bug 1333122 - Remove some uses of gfxPrefs::WebRenderEnabled from gfx code.

https://reviewboard.mozilla.org/r/106612/#review107630

Comment 9

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8829557 [details]
Bug 1333122 - Use the CompositorOptions to determine the appropriate LayerManager to create for content-process tabs.

https://reviewboard.mozilla.org/r/106610/#review107632

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Shoot, I lost a hunk during rebasing. New patches coming.

Comment 11

[Kartikaya Gupta (email:[e-mail])]

(The missing hunk had already been reviewed by dvander in bug 1326421 so I guess I can just carry the r+ for that)

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8829557 [details]
Bug 1333122 - Use the CompositorOptions to determine the appropriate LayerManager to create for content-process tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106610/diff/1-2/

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8829558 [details]
Bug 1333122 - Remove some uses of gfxPrefs::WebRenderEnabled from gfx code.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106612/diff/1-2/

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8829559 [details]
Bug 1333122 - Start and stop the RenderThread in any webrender-enabled builds.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106614/diff/1-2/

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8829560 [details]
Bug 1333122 - Remove gfxPrefs::WebRenderEnabled() to avoid it being used inappopriately; do WR and APZ decision-making during compositor creation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106616/diff/1-2/

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8829561 [details]
Bug 1333122 - Condition disabling of buffer-rotation on the layer tree rather than a compile-time flag.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106618/diff/1-2/

Comment 17

[Nicolas Silva [:nical]]

Comment on attachment 8829559 [details]
Bug 1333122 - Start and stop the RenderThread in any webrender-enabled builds.

https://reviewboard.mozilla.org/r/106614/#review107634

Comment 18

[Ethan Lin[:ethlin]]

Comment on attachment 8829561 [details]
Bug 1333122 - Condition disabling of buffer-rotation on the layer tree rather than a compile-time flag.

https://reviewboard.mozilla.org/r/106618/#review107724

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/b7619d5557e0
Use the CompositorOptions to determine the appropriate LayerManager to create for content-process tabs. r=dvander
https://hg.mozilla.org/projects/graphics/rev/5facc8050cc1
Remove some uses of gfxPrefs::WebRenderEnabled from gfx code. r=sotaro
https://hg.mozilla.org/projects/graphics/rev/e71e873893d9
Start and stop the RenderThread in any webrender-enabled builds. r=nical
https://hg.mozilla.org/projects/graphics/rev/e9d5bf60fd9f
Remove gfxPrefs::WebRenderEnabled() to avoid it being used inappopriately; do WR and APZ decision-making during compositor creation. r=dvander?
https://hg.mozilla.org/projects/graphics/rev/6c0b2aee8144
Condition disabling of buffer-rotation on the layer tree rather than a compile-time flag. r=ethlin

Comment 20

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8829560 [details]
Bug 1333122 - Remove gfxPrefs::WebRenderEnabled() to avoid it being used inappopriately; do WR and APZ decision-making during compositor creation.

https://reviewboard.mozilla.org/r/106616/#review108844