Closed Bug 1333135 Opened 8 years ago Closed 8 years ago

Ensure test support binaries are tracked by install manifests

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox54 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(3 files)

Bug 1333135 - Install test programs from xpcom/tests with moz.build rather than Makefile.in.
59 bytes, text/x-review-board-request
mshal
: review+
Details
Bug 1333135 - Ensure test support binaries are tracked by install manifests in the build backend.
59 bytes, text/x-review-board-request
mshal
: review+
Details
Bug 1333135 - Do not attempt to install SIMPLE_PROGRAMS during MOZ_PROFILE_GENERATE.
59 bytes, text/x-review-board-request
mshal
: review+
Details
A few tests that should be fixed by bug 1330421 are still failing due to support programs/files that are installed by Makefile.in. These look like straightforward translations to TEST_HARNESS_FILES for the most part.
Assignee: nobody → cmanchester
I found a few other cases to fix here, re-summarizing to match.
Summary: Install test support files with moz.build rather than Makefile.in → Ensure test support binaries are tracked by install manifests
Comment on attachment 8830528 [details] Bug 1333135 - Install test programs from xpcom/tests with moz.build rather than Makefile.in. https://reviewboard.mozilla.org/r/107264/#review108704 Nice, one line to go to get rid of that Makefile :)
Attachment #8830528 - Flags: review?(mshal) → review+
Comment on attachment 8830529 [details] Bug 1333135 - Ensure test support binaries are tracked by install manifests in the build backend. https://reviewboard.mozilla.org/r/107266/#review108706 Should the _process_test_support_file() function be called on something more generic, like all Linkable objects? As-is, if someone installs something to _tests that is not a SharedLibrary or SimpleProgram, it won't find its way into the install manifest (eg: maybe someone needs a StaticLibrary or HostSimpleProgram in a test). I'm not sure if that would ever be relevant, but it might be worth considering.
Attachment #8830529 - Flags: review?(mshal) → review+
Comment on attachment 8830529 [details] Bug 1333135 - Ensure test support binaries are tracked by install manifests in the build backend. https://reviewboard.mozilla.org/r/107266/#review108706 Good suggestions, although I don't think it will impact things right now. It might be a little tricky to get the target file's basename for each type, but I'll take a look.
Attachment #8830529 - Flags: review+ → review?(mshal)
Comment on attachment 8830529 [details] Bug 1333135 - Ensure test support binaries are tracked by install manifests in the build backend. https://reviewboard.mozilla.org/r/107266/#review109310 LGTM!
Attachment #8830529 - Flags: review?(mshal) → review+
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aff814e1eebb Install test programs from xpcom/tests with moz.build rather than Makefile.in. r=mshal https://hg.mozilla.org/integration/autoland/rev/deb7b3426d0a Ensure test support binaries are tracked by install manifests in the build backend. r=mshal
Backed out for Linux pgo bustage (doesn't know how to make TestArguments): https://hg.mozilla.org/integration/autoland/rev/83e1a88a9833a498a0e841e37a822de99b0ed0c6 https://hg.mozilla.org/integration/autoland/rev/a4468c4cc24e640cfa7306db2c1735fa45a94633 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=deb7b3426d0a43253c0e76f24a1de310f8cab103 Failure log: [task 2017-01-30T19:01:08.627194Z] 19:01:08 INFO - gmake[6]: Entering directory '/home/worker/workspace/build/src/obj-firefox/xpcom/tests' [task 2017-01-30T19:01:08.627788Z] 19:01:08 INFO - ../../config/nsinstall -R -m 644 '../../dist/bin/components/xpcomtest.xpt' '../../_tests/xpcshell/xpcom/tests/unit' [task 2017-01-30T19:01:08.628181Z] 19:01:08 INFO - gmake[6]: *** No rule to make target 'TestArguments', needed by '../../_tests/xpcshell/xpcom/tests/unit/TestArguments'. Stop. [task 2017-01-30T19:01:08.627194Z] 19:01:08 INFO - gmake[6]: Entering directory '/home/worker/workspace/build/src/obj-firefox/xpcom/tests' [task 2017-01-30T19:01:08.627788Z] 19:01:08 INFO - ../../config/nsinstall -R -m 644 '../../dist/bin/components/xpcomtest.xpt' '../../_tests/xpcshell/xpcom/tests/unit' [task 2017-01-30T19:01:08.628181Z] 19:01:08 INFO - gmake[6]: *** No rule to make target 'TestArguments', needed by '../../_tests/xpcshell/xpcom/tests/unit/TestArguments'. Stop.
Flags: needinfo?(cmanchester)
I think the issue is that we don't build SIMPLE_PROGRAMS when MOZ_PROFILE_GENERATE is set. Not exactly sure how to work around that.
I guess we might be able to skip installing to _tests if MOZ_PROFILE_GENERATE is set. Testing that on try now.
Flags: needinfo?(cmanchester)
Comment on attachment 8832291 [details] Bug 1333135 - Do not attempt to install SIMPLE_PROGRAMS during MOZ_PROFILE_GENERATE. https://reviewboard.mozilla.org/r/108614/#review110056 Looks good!
Attachment #8832291 - Flags: review?(mshal) → review+
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c22103c91289 Do not attempt to install SIMPLE_PROGRAMS during MOZ_PROFILE_GENERATE. r=mshal https://hg.mozilla.org/integration/autoland/rev/55e597a315cd Install test programs from xpcom/tests with moz.build rather than Makefile.in. r=mshal https://hg.mozilla.org/integration/autoland/rev/d79003eb1511 Ensure test support binaries are tracked by install manifests in the build backend. r=mshal
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: