Cannot remove breakpoint when it's set at non-script area

RESOLVED FIXED in Firefox 55

Status

defect
P2
normal
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: yury, Assigned: jlast)

Tracking

unspecified
Firefox 55

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

Posted file test file
STR:
1. Open the attached file in the debugger
2. Set a breakpoint below the main code by clicking margin near
3. Remove this breakpoint

Actual result: cannot remove the breakpoint.

Expected result: it's possible to remove the breakpoint, or don't allow to set it.
The doc at https://wiki.mozilla.org/Remote_Debugging_Protocol#Breakpoints mentions 'noCodeAtLineColumn' error, but we never raise that.
Comment on attachment 8831783 [details]
Bug 1333219 - Allow setBreakpoint on server fail when script is absent.

I don't feel confident reviewing that. I would prefer someone with debugger experience to look at it.
Attachment #8831783 - Flags: review?(poirot.alex) → review?(jlaster)
Assignee: nobody → jlaster
Status: NEW → ASSIGNED
Priority: -- → P2
Comment on attachment 8831783 [details]
Bug 1333219 - Allow setBreakpoint on server fail when script is absent.

https://reviewboard.mozilla.org/r/108322/#review119268

This looks good. Thanks for the help and being consistent with the protocol: https://wiki.mozilla.org/Remote_Debugging_Protocol#Breakpoints
Attachment #8831783 - Flags: review?(jlaster) → review+
Pushed by ydelendik@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b80052cdc2e1
Allow setBreakpoint on server fail when script is absent. r=jlast
https://hg.mozilla.org/mozilla-central/rev/b80052cdc2e1
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this bug with Nightly 54.0a1 (2017-01-23) (64-bit) on WIndows 7 , 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID          20170308030207
User Agent        Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170308]
I have reproduced this bug with nightly 53.0a1 (2017-01-23) (64-bit) on "Linux Mint 18.1 Serena"(64 Bit).

The bug's fix is now verified on Latest nightly 55.0a1.

Build ID 	20170524100215
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[Bugday-20170525]
QA Whiteboard: [bugday-20170524]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.