1333219 - Cannot remove breakpoint when it's set at non-script area

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Yury Delendik (:yury)]

Attachment: test file

STR:
1. Open the attached file in the debugger
2. Set a breakpoint below the main code by clicking margin near
3. Remove this breakpoint

Actual result: cannot remove the breakpoint.

Expected result: it's possible to remove the breakpoint, or don't allow to set it.

Comment 1

[Yury Delendik (:yury)]

Attachment: Bug 1333219 - Allow setBreakpoint on server fail when script is absent.

Review commit: https://reviewboard.mozilla.org/r/108322/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108322/

Comment 2

[Yury Delendik (:yury)]

The doc at https://wiki.mozilla.org/Remote_Debugging_Protocol#Breakpoints mentions 'noCodeAtLineColumn' error, but we never raise that.

Comment 3

[Alexandre Poirot [:ochameau] [PTO back Jan 5th]]

Comment on attachment 8831783 [details]
Bug 1333219 - Allow setBreakpoint on server fail when script is absent.

I don't feel confident reviewing that. I would prefer someone with debugger experience to look at it.

Comment 4

[Jason Laster [:jlast]]

Comment on attachment 8831783 [details]
Bug 1333219 - Allow setBreakpoint on server fail when script is absent.

https://reviewboard.mozilla.org/r/108322/#review119268

This looks good. Thanks for the help and being consistent with the protocol: https://wiki.mozilla.org/Remote_Debugging_Protocol#Breakpoints

Comment 5

[Yury Delendik (:yury)]

Comment on attachment 8831783 [details]
Bug 1333219 - Allow setBreakpoint on server fail when script is absent.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108322/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b80052cdc2e1
Allow setBreakpoint on server fail when script is absent. r=jlast

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b80052cdc2e1

Comment 8

[Md Maruf Rahman]

I have reproduced this bug with Nightly 54.0a1 (2017-01-23) (64-bit) on WIndows 7 , 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID          20170308030207
User Agent        Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170308]

Comment 9

[Md.Tarikul Islam Oashi]

I have reproduced this bug with nightly 53.0a1 (2017-01-23) (64-bit) on "Linux Mint 18.1 Serena"(64 Bit).

The bug's fix is now verified on Latest nightly 55.0a1.

Build ID 	20170524100215
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[Bugday-20170525]