1333251 - Change permission prompt to say ''Access recently closed tabs"

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[krupa raj [:krupa--use this to needinfo]]

[setup]
a. Launch Firefox with clean profile.
b. Create extensions.webextPermissionPrompts and set it to true

[Steps to reproduce]:
1. Load https://addons-dev.allizom.org/en-US/firefox/addon/webext-permissions-all-perms
2. Click on the install button
3. Notice the list of permissions in the doorhanger, specifically "Access browser recently closed tabs"

[expected behavior]
The permission says "Access recently closed tabs"


[screenshot]
https://www.dropbox.com/s/cneskq7q20fmd5d/Screenshot%202017-01-23%2013.14.09.png?dl=0

Comment 1

[Andrew Swan [:aswan]]

Francisco, I made an error updating this string (webextPerms.description.sessions, landed as "Access browser recently closed tabs" but should be "Access recently closed tabs").  What's the process for deciding if we can land/uplift a change?  I think this is just clarifying and not changing the meaning...

Comment 2

[Francesco Lodolo [:flod]]

(In reply to Andrew Swan [:aswan] from comment #1)
> Francisco, I made an error updating this string
> (webextPerms.description.sessions, landed as "Access browser recently closed
> tabs" but should be "Access recently closed tabs").  What's the process for
> deciding if we can land/uplift a change?  I think this is just clarifying
> and not changing the meaning...

1. Create a patch, in this case the general meaning is clear and you can avoid changing the string ID.
2. Land in mozilla-central, ask for approval for mozilla-aurora. That's up to release-drivers at that point, I'm OK with uplifting this to aurora, they'll still need the l10n=XXXX flag in the commit to avoid the block.

You should try to do #2 as soon as possible, because this is going to create noise in some tools, invalidating the existing translation.

FYI, this is the main reason I don't like strings crash-landing in m-c the last days of the cycle, especially when it's been such a long one (I'm sure there were good reasons for the delay, just stating the problem).

Comment 3

[Francesco Lodolo [:flod]]

BTW, I'm trying to install the add-on on a new profile to test the localized dialog, and it says the packaged is corrupted. I downloaded the XPI and I can't even unpack it.

It would be really helpful for testing. Can I share it with localizers, i.e. is the add-on going to remain available for a while?
Do you know who can verify what the problem is?

Comment 4

[Francesco Lodolo [:flod]]

Directing to :kraj, since it seems to be the author of the add-on in question.

Comment 5

[krupa raj [:krupa--use this to needinfo]]

Attachment: allperms.zip

Let me know if the attached add-on works for you

Comment 6

[Andrew Swan [:aswan]]

Attachment: Bug 1333251 Fix typo in permission string l10n=flod

Review commit: https://reviewboard.mozilla.org/r/106882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106882/

Comment 7

[Andrew Swan [:aswan]]

That extension appears to be unsigned but since you'll be testing on Aurora or Nightly, you (or other translators) can install it by flipping the value of the preference xpinstall.signatures.required to false.

Comment 8

[Francesco Lodolo [:flod]]

(In reply to kraj from comment #5)
> Created attachment 8829917 [details]
> allperms.zip
> 
> Let me know if the attached add-on works for you

Renamed to XPI, tried installing it (it talks about "Awesome screenshot?") but no permission dialog displayed.

Comment 9

[Francesco Lodolo [:flod]]

Comment on attachment 8829919 [details]
Bug 1333251 Fix typo in permission string l10n=flod

https://reviewboard.mozilla.org/r/106882/#review107966

Comment 10

[Andrew Swan [:aswan]]

(In reply to Francesco Lodolo [:flod] from comment #8)
> Renamed to XPI, tried installing it (it talks about "Awesome screenshot?")
> but no permission dialog displayed.

Right, sorry, the prompts are not yet enabled by default, you need to create the preference "extensions.webextPermissionPrompts" and set it to true.

Comment 11

[Andrew Swan [:aswan]]

Comment on attachment 8829919 [details]
Bug 1333251 Fix typo in permission string l10n=flod

Approval Request Comment
[Feature/Bug causing the regression]:
bug 1316996

[User impact if declined]:
This patch simply clarifies a string that appears in the UI.  Without this patch, users will see a confusingly worded message.

[Is this code covered by automated tests?]:
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]:
[Why is the change risky/not risky?]:
N/A to all of the above

[String changes made/needed]:
This patch is a string change, it has l10n approval from flod.

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Andrew Swan [:aswan] from comment #10)
> Right, sorry, the prompts are not yet enabled by default, you need to create
> the preference "extensions.webextPermissionPrompts" and set it to true.

It's on me, it was in the first comment, but I didn't realize I was testing on a different profile. After testing, I confess the question mark, displayed on its own in the dialog's title, looks quite awkward.

Comment 13

[Andrew Swan [:aswan]]

(In reply to Francesco Lodolo [:flod] from comment #12)
> It's on me, it was in the first comment, but I didn't realize I was testing
> on a different profile. After testing, I confess the question mark,
> displayed on its own in the dialog's title, looks quite awkward.

That is bug 1333168 which is stumping me since I see it sometimes but not all the time...

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7ab800cfeee
Fix typo in permission string l10n=flod r=flod

Comment 15

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b7ab800cfeee

Comment 16

[Gerry Chang [:gchang]]

Comment on attachment 8829919 [details]
Bug 1333251 Fix typo in permission string l10n=flod

Fix a typo and have :flod's approval. Aurora53+.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f0e4b9855df1