Closed Bug 1333262 Opened 7 years ago Closed 7 years ago

On re-installing an add-on get the update permission prompt

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: andy+bugzilla, Assigned: aswan)

References

Details

Attachments

(1 file)

1. Install an add-on
2. Upgrade an add-on to a newer version with more permissions
3. Accept the upgrade
4. Uninstall the add-on
5. Reinstall the first version of the add-on

The prompt looks like this:

https://www.dropbox.com/s/15thxi5pp4zdq7h/Screenshot%202017-01-23%2017.26.21.png?dl=0

Which is more like the upgrade prompt than the install first time prompt. For example clicking cancel does not leave me with the current version, but no version at all.
Comment on attachment 8829710 [details]
Bug 1333262 Set notification text unconditionally

https://reviewboard.mozilla.org/r/106722/#review107828

Looks OK, although I wonder if it would be preferable to do .hidden = !text;

(I'm not sure if an empty but visible <description> will have visible consequences, eg. an empty line in the panel)
Attachment #8829710 - Flags: review?(florian) → review+
Assignee: nobody → aswan
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab55dc7c08c6
Set notification text unconditionally r=florian
https://hg.mozilla.org/mozilla-central/rev/ab55dc7c08c6
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: