1333262 - On re-installing an add-on get the update permission prompt

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Andy McKay]

1. Install an add-on
2. Upgrade an add-on to a newer version with more permissions
3. Accept the upgrade
4. Uninstall the add-on
5. Reinstall the first version of the add-on

The prompt looks like this:

https://www.dropbox.com/s/15thxi5pp4zdq7h/Screenshot%202017-01-23%2017.26.21.png?dl=0

Which is more like the upgrade prompt than the install first time prompt. For example clicking cancel does not leave me with the current version, but no version at all.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1333262 Set notification text unconditionally

Review commit: https://reviewboard.mozilla.org/r/106722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106722/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8829710 [details]
Bug 1333262 Set notification text unconditionally

https://reviewboard.mozilla.org/r/106722/#review107828

Looks OK, although I wonder if it would be preferable to do .hidden = !text;

(I'm not sure if an empty but visible <description> will have visible consequences, eg. an empty line in the panel)

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8829710 [details]
Bug 1333262 Set notification text unconditionally

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/106722/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab55dc7c08c6
Set notification text unconditionally r=florian

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab55dc7c08c6