Closed Bug 1333302 Opened 4 years ago Closed 4 years ago
Permafailing Windows static analysis builds on aurora 53
59 bytes, text/x-review-board-request
One of three things keeping aurora closed after the merge. https://treeherder.mozilla.org/logviewer.html#?job_id=71196064&repo=mozilla-aurora https://treeherder.mozilla.org/logviewer.html#?job_id=71196065&repo=mozilla-aurora 16:24:06 INFO - Creating library fakeopenh264.lib and object fakeopenh264.exp 16:24:06 INFO - LINK : fatal error LNK1264: /GENPROFILE specified but no code generation required; instrumentation failed
from talking to glandium in irc this seems to be a releng issue 07:37 < glandium> Tomcat|sheriffduty: something, whatever it is, is setting MOZ_PGO on those builds. They're not supposed to be PGO. They are not PGO on m-c/m-i, and they can't be PGO, because they use clang-cl
Component: Build Config → Buildduty
Product: Core → Release Engineering
QA Contact: bugspam.Callek
Version: 53 Branch → unspecified
glandium told me this could be hidden till we fixed this and so created https://treeherder.mozilla.org/admin.html#/exclusions/189 but somehow treeherder does not hide this so far (wes, do you know what i did wrong ?
You didn't select "opt" in the Option Collections.
Someone added the opt type before I got in, as these jobs only show when I stop hiding excluded jobs.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
This wasn't a bug about hiding them, it was a bug about fixing them.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
And, waitaminute, we *hid* a tier-1 build because it was broken? That means it's not tier-1, the only way that that would be an acceptable solution would be to either declare it tier-3 on every tree where it runs, or to declare that we didn't actually want to run it on aurora, and stop running it there rather than hide it. Unhidden.
Status: REOPENED → NEW
https://dxr.mozilla.org/build-central/source/mozharness/mozharness/mozilla/building/buildbase.py#882 looks an awful lot like something that would cause every Windows build on aurora to be PGO.
Component: Buildduty → Mozharness
QA Contact: bugspam.Callek → jlund
(In reply to Phil Ringnalda (:philor) from comment #7) > https://dxr.mozilla.org/build-central/source/mozharness/mozharness/mozilla/ > building/buildbase.py#882 looks an awful lot like something that would cause > every Windows build on aurora to be PGO. bingo! not every windows build though, just the official opt builds on branches run pgo by default on checkin: "pgo_platforms": ['linux', 'linux64', 'win32', 'win64'] https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/fx_desktop_build.py#57 https://dxr.mozilla.org/mozilla-central/search?q=branch_uses_per_checkin_strategy+path%3Abranch_specifics&redirect=true the problem here is that these clang builds are impersonating the opt equivalents listed in pgo_platforms: e.g. 16:21:07 INFO - 'stage_platform': 'win32', 16:21:07 INFO - 'branch_uses_per_checkin_strategy': True,
Attachment #8830270 - Flags: review?(pmoore) → review?(wcosta)
I'm afraid I can only rubber stamp here... Wander, could you take a look? Thanks!
Comment on attachment 8830270 [details] Bug 1333302 - Permafailing Windows static analysis builds on aurora 53, https://reviewboard.mozilla.org/r/107152/#review108272
Attachment #8830270 - Flags: review?(wcosta) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/1f99fbc86225 Permafailing Windows static analysis builds on aurora 53, r=wcosta
You need to log in before you can comment on or make changes to this bug.