Closed Bug 1333302 Opened 5 years ago Closed 5 years ago

Permafailing Windows static analysis builds on aurora 53


(Release Engineering :: Applications: MozharnessCore, defect)

Not set


(firefox53 verified, firefox54 fixed)

Tracking Status
firefox53 --- verified
firefox54 --- fixed


(Reporter: philor, Assigned: jlund)




(1 file)

One of three things keeping aurora closed after the merge.

16:24:06     INFO -     Creating library fakeopenh264.lib and object fakeopenh264.exp
16:24:06     INFO -  LINK : fatal error LNK1264: /GENPROFILE specified but no code generation required; instrumentation failed
from talking to glandium in irc this seems to be a releng issue

07:37 < glandium> Tomcat|sheriffduty: something, whatever it is, is setting MOZ_PGO on those builds. They're not supposed to be PGO. They are not PGO on m-c/m-i, and they can't be PGO, because they 
                  use clang-cl
Component: Build Config → Buildduty
Product: Core → Release Engineering
QA Contact: bugspam.Callek
Version: 53 Branch → unspecified
glandium told me this could be hidden till we fixed this and so created but somehow treeherder does not hide this so far (wes, do you know what i did wrong ?
Flags: needinfo?(wkocher)
You didn't select "opt" in the Option Collections.
Flags: needinfo?(wkocher)
Someone added the opt type before I got in, as these jobs only show when I stop hiding excluded jobs.
Closed: 5 years ago
Resolution: --- → FIXED
This wasn't a bug about hiding them, it was a bug about fixing them.
Resolution: FIXED → ---
And, waitaminute, we *hid* a tier-1 build because it was broken? That means it's not tier-1, the only way that that would be an acceptable solution would be to either declare it tier-3 on every tree where it runs, or to declare that we didn't actually want to run it on aurora, and stop running it there rather than hide it.

Status: REOPENED → NEW looks an awful lot like something that would cause every Windows build on aurora to be PGO.
Component: Buildduty → Mozharness
Flags: needinfo?(jlund)
QA Contact: bugspam.Callek → jlund
Blocks: 1321444
Flags: needinfo?(jlund)
Assignee: nobody → jlund
(In reply to Phil Ringnalda (:philor) from comment #7)
> building/ looks an awful lot like something that would cause
> every Windows build on aurora to be PGO.


not every windows build though, just the official opt builds on branches run pgo by default on checkin: "pgo_platforms": ['linux', 'linux64', 'win32', 'win64']

the problem here is that these clang builds are impersonating the opt equivalents listed in pgo_platforms:
16:21:07     INFO -  'stage_platform': 'win32',
16:21:07     INFO -  'branch_uses_per_checkin_strategy': True,
Attachment #8830270 - Flags: review?(pmoore) → review?(wcosta)
I'm afraid I can only rubber stamp here...

Wander, could you take a look?

Comment on attachment 8830270 [details]
Bug 1333302 - Permafailing Windows static analysis builds on aurora 53,
Attachment #8830270 - Flags: review?(wcosta) → review+
Pushed by
Permafailing Windows static analysis builds on aurora 53, r=wcosta
Green builds on Aurora \m/
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.