1333304 - PlacesUtils.bookmarks.reorder fails when reordering an empty folder when a non-empty list of children is passed.

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

This is a bit of an edge case, but reorder documents for the orderedChildrenGuids param that "If this list contains non-existing entries they will be ignored". However, if the folder you are trying to order has no children it throws with:

> Unexpected exception TypeError: sortedChildren is undefined at resource://gre/modules/Bookmarks.jsm:732 ...

This should probably just work (ie, silently do nothing).

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1333304 - fix reordering an empty folder when missing children are specified.

Review commit: https://reviewboard.mozilla.org/r/106730/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106730/

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 8829731 [details]
Bug 1333304 - fix reordering an empty folder when missing children are specified.

https://reviewboard.mozilla.org/r/106730/#review108324

thank you!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17a37753fc3d
fix reordering an empty folder when missing children are specified. r=mak

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/364a3514cddc
followup, please eslint by using double quotes

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/17a37753fc3d
https://hg.mozilla.org/mozilla-central/rev/364a3514cddc