Closed Bug 1333304 Opened 5 years ago Closed 5 years ago
Utils .bookmarks .reorder fails when reordering an empty folder when a non-empty list of children is passed .
59 bytes, text/x-review-board-request
This is a bit of an edge case, but reorder documents for the orderedChildrenGuids param that "If this list contains non-existing entries they will be ignored". However, if the folder you are trying to order has no children it throws with: > Unexpected exception TypeError: sortedChildren is undefined at resource://gre/modules/Bookmarks.jsm:732 ... This should probably just work (ie, silently do nothing).
Assignee: nobody → markh
Priority: -- → P1
Comment on attachment 8829731 [details] Bug 1333304 - fix reordering an empty folder when missing children are specified. https://reviewboard.mozilla.org/r/106730/#review108324 thank you!
Attachment #8829731 - Flags: review?(mak77) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/17a37753fc3d fix reordering an empty folder when missing children are specified. r=mak
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/364a3514cddc followup, please eslint by using double quotes
You need to log in before you can comment on or make changes to this bug.