1333323 - Enable out-of-process media decoding for all versions (Remove nightly flag)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P1)

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: Bug 1333323 - remove nightly flag to enable OOP decoding for all versions.

Review commit: https://reviewboard.mozilla.org/r/106762/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/106762/

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8829755 [details]
Bug 1333323 - remove nightly flag to enable OOP decoding for all versions.

https://reviewboard.mozilla.org/r/106762/#review107898

This does seem to be working pretty well on Nightly. Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cf58802b19f
remove nightly flag to enable OOP decoding for all versions. r=snorp

Comment 4

[Blake Wu [:bwu][:blakewu]]

John, 
We will uplift to aurora 53, right?

Comment 5

[John Lin [:jhlin][:jolin]]

Yes, once it's landed in central.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0cf58802b19f

Comment 7

[John Lin [:jhlin][:jolin]]

Comment on attachment 8829755 [details]
Bug 1333323 - remove nightly flag to enable OOP decoding for all versions.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1257777
[User impact if declined]: Fennec will crash when something goes wrong in Android media framework.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Yes. STR -- https://wiki.mozilla.org/QA/Fennec/Move_Android_decoder_out_of_app_process#Acceptance_Criteria
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low risk.
[Why is the change risky/not risky?]: It has been enabled in Nightly for several weeks and all found bugs have been fixed.
[String changes made/needed]: None

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8829755 [details]
Bug 1333323 - remove nightly flag to enable OOP decoding for all versions.

Out-of-process media decoding will be in 53. Aurora53+.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/09e755555ba5

Comment 10

[Eric Shepherd [:sheppy]]

Noted on Firefox 53 for developers.