Enable out-of-process media decoding for all versions (Remove nightly flag)

RESOLVED FIXED in Firefox 53

Status

()

Firefox for Android
Audio/Video
P1
normal
RESOLVED FIXED
4 months ago
a month ago

People

(Reporter: jolin, Assigned: jolin)

Tracking

({dev-doc-complete})

unspecified
Firefox 53
dev-doc-complete
Points:
---

Firefox Tracking Flags

(firefox53 fixed, firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

4 months ago
Assignee: nobody → jolin
Comment hidden (mozreview-request)

Comment 2

4 months ago
mozreview-review
Comment on attachment 8829755 [details]
Bug 1333323 - remove nightly flag to enable OOP decoding for all versions.

https://reviewboard.mozilla.org/r/106762/#review107898

This does seem to be working pretty well on Nightly. Thanks!
Attachment #8829755 - Flags: review?(snorp) → review+

Comment 3

4 months ago
Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0cf58802b19f
remove nightly flag to enable OOP decoding for all versions. r=snorp
John, 
We will uplift to aurora 53, right?
Flags: needinfo?(jolin)
Priority: -- → P1
Target Milestone: --- → Firefox 53
(Assignee)

Comment 5

4 months ago
Yes, once it's landed in central.
Flags: needinfo?(jolin)

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0cf58802b19f
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
(Assignee)

Comment 7

4 months ago
Comment on attachment 8829755 [details]
Bug 1333323 - remove nightly flag to enable OOP decoding for all versions.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1257777
[User impact if declined]: Fennec will crash when something goes wrong in Android media framework.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Yes. STR -- https://wiki.mozilla.org/QA/Fennec/Move_Android_decoder_out_of_app_process#Acceptance_Criteria
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Low risk.
[Why is the change risky/not risky?]: It has been enabled in Nightly for several weeks and all found bugs have been fixed.
[String changes made/needed]: None
Attachment #8829755 - Flags: approval-mozilla-aurora?

Updated

4 months ago
status-firefox53: --- → affected

Comment 8

4 months ago
Comment on attachment 8829755 [details]
Bug 1333323 - remove nightly flag to enable OOP decoding for all versions.

Out-of-process media decoding will be in 53. Aurora53+.
Attachment #8829755 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 9

4 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/09e755555ba5
status-firefox53: affected → fixed
Noted on Firefox 53 for developers.
Keywords: dev-doc-complete
You need to log in before you can comment on or make changes to this bug.