1333386 - Use {once: true} for window "load" event listener

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jan Henning [:JanH]]

I've learnt about this only after the landing of bug 1332863 was already in progress - instead of removing the listener from within its own function, we can now simply call addEventListener with {once: true}, which also means we don't have to worry any more about storing a reference to the function.

Because it looks like this won't be covered by the automatic conversion in bug 1331599 [1], I'll do it separately instead.

[1] Because I'm using an arrow function to avoid having to rebind "this", I have to capture the listener into a variable before adding it, so I have a function reference I can later call removeEventListener with.

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1333386 - Use {once: true} for session store window "load" listener.

Review commit: https://reviewboard.mozilla.org/r/107228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/107228/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8830474 [details]
Bug 1333386 - Use {once: true} for session store window "load" listener.

https://reviewboard.mozilla.org/r/107228/#review108518

Comment 3

[Jan Henning [:JanH]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=874de7943b6f5d671ea7d98a2e66c7aee1e61c9f

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a041cbe31bb
Use {once: true} for session store window "load" listener. r=sebastian

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7a041cbe31bb