1333396 - Add a dropdown list showing recent revisions while annotating jobs when using "fixed by commit"

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[anejaalisha]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161209095719

Steps to reproduce:

Classify jobs by "fixed by commit"


Actual results:

When classifying jobs by "fixed by commit", it is mandatory to atleast write 8 characters for the annotation, so it should not go as an empty string.


Expected results:

A dropdown button should be added that suggests recent revisions, which can be chosen for annotation.

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] alisha17:bug1323536-Make-text-field-for-annotating-jobs-mandatory-when-using-fixedbycommit > mozilla:master

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8829836 [details] [review]
[treeherder] alisha17:bug1323536-Make-text-field-for-annotating-jobs-mandatory-when-using-fixedbycommit > mozilla:master

Thanks for the pull request!  I made some suggestions on streamlining this.  Would you mind making a few updates and then re-submitting it?  Thanks!!  :)

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8829836 [details] [review]
[treeherder] alisha17:bug1323536-Make-text-field-for-annotating-jobs-mandatory-when-using-fixedbycommit > mozilla:master

This is just about there.  The only thing is you're injecting ``$location`` in a class that doesn't need it anymore.  If you can just remove that and re-assign it to me, we'll be done.

Thanks for working on this! :)

Comment 4

[Cameron Dawson [:camd]]

Alisha--  The code looks great now.  But would you please reformat your commit message for this?

Something like: Bug 1333396 - Add commit suggestions drop-down for 'fixed by commit'

We require this format for our commits.  I apologize I didn't notice this earlier.

Comment 5

[anejaalisha]

Reformatted the commit message! :)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/3cca2fe20c4b4aef1902ea3ca9ab02755b493885
Bug 1333396 - Add commit suggestions drop-down for 'fixed by commit' (#2095)

Comment 7

[Cameron Dawson [:camd]]

Thanks for the work, Alisha!  :)