Closed
Bug 1333422
Opened 8 years ago
Closed 8 years ago
Treeherder attempts to get the size of a non-existent element, causing a console error
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
Details
Attachments
(1 file)
We have some code which tries to get the size of a non-existent "top navbar" to adjust the size of the resultset/jobs view. I think this dates way back to 2014, before I added flexbox-- the code is harmless (since it does nothing), but causes a confusing console error (Empty string passed to getElementById). Let's remove it.
|
||
Comment 1•8 years ago
|
||
|
Assignee | |
Updated•8 years ago
|
Attachment #8829882 -
Flags: review?(james)
|
||
Updated•8 years ago
|
Attachment #8829882 -
Flags: review?(james) → review+
|
||
Comment 2•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/45eb37327670fe6a61811f5b8aef425e546252f0
Bug 1333422 - Remove useless resize-watching code from ui (#2099)
We have some code which tries to get the size of a non-existent "top navbar"
to adjust the size of the resultset/jobs view. I think this dates way back
to 2014, before I made the ui use flexbox for layout-- the code is harmless
(since it does nothing), but causes a confusing console error ("Empty string
passed to getElementById"). Let's remove it.
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•