1333490 - wasm: pass a few more shared tests

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P1)

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Derailing this bug to include more fixes to the shared test suite.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: _1-tostringtag.patch

Defines toStringTag for wasm prototypes.

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: _2.instantiatelength.patch

Instantiate.length should be 1, not 2:
https://github.com/bnjbvr/wasm-spec/pull/1#discussion_r97571381

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: _3.typerror.patch

Filed https://github.com/WebAssembly/spec/pull/426 for upstream fix.

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 8838669 [details] [diff] [review]
_1-tostringtag.patch

Review of attachment 8838669 [details] [diff] [review]:
-----------------------------------------------------------------

Great to see this fixed; one request:

::: js/src/vm/CommonPropertyNames.h
@@ +378,5 @@
>      macro(wasmcall, wasmcall, "wasmcall") \
> +    macro(WebAssemblyModule, WebAssemblyModule, "WebAssembly.Module") \
> +    macro(WebAssemblyInstance, WebAssemblyInstance, "WebAssembly.Instance") \
> +    macro(WebAssemblyMemory, WebAssemblyMemory, "WebAssembly.Memory") \
> +    macro(WebAssemblyTable, WebAssemblyTable, "WebAssembly.Table") \

Common property names are useful for hot cases where it's useful to always have an atom available.  These 4 are only used once, during lazy wasm initialization, so I'd rather leave them out of this list.

::: js/src/wasm/WasmJS.cpp
@@ +2113,5 @@
>  
>      RootedObject moduleProto(cx), instanceProto(cx), memoryProto(cx), tableProto(cx);
>      if (!InitConstructor<WasmModuleObject>(cx, wasm, "Module", &moduleProto))
>          return nullptr;
> +    if (!DefineToStringTag(cx, moduleProto, cx->names().WebAssemblyModule))

Could you push this into InitConstructor?  It already does some atomization on `name, so you could programmatically build `WebAssembly.${name}`.

Comment 6

[Luke Wagner [:luke]]

Comment on attachment 8838671 [details] [diff] [review]
_3.typerror.patch

Review of attachment 8838671 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8838671 [details] [diff] [review]
_3.typerror.patch

For what it's worth, I've discarded this patch by rearranging my local patch queue for bug 1332691. All these patches will land together.

Comment 8

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: tostringtag.patch

Comment 9

[Luke Wagner [:luke]]

Comment on attachment 8840509 [details] [diff] [review]
tostringtag.patch

Review of attachment 8840509 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: js/src/wasm/WasmJS.cpp
@@ +2071,5 @@
>          return false;
>  
> +    UniqueChars tagStr(JS_smprintf("WebAssembly.%s", name));
> +    if (!tagStr)
> +        return false;

return ReportOutOfMemory(cx)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/71cc6bef1788
Define toStringTag for wasm prototypes; r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/339878f975cc
Change WebAssembly.instantiate.length to 1; r=luke

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/71cc6bef1788
https://hg.mozilla.org/mozilla-central/rev/339878f975cc