1333495 - Fix and reenable various webgl tests that use random images on the web

Status: REOPENED

(Core :: Graphics: CanvasWebGL, task, P3)

Description

[Boris Zbarsky [:bzbarsky]]

The webgl testsuite uses random images on the web.  This is totally busted, and I filed https://github.com/KhronosGroup/WebGL/issues/2273 on that, but in the meantime...

What we should probably do is add the two hostnames involved to our test HTTP server and map the relevant paths to something in-tree.  Then I expect we can remove several "skip-if = 1" from dom/canvas/test/webgl-conf/generated-mochitest.ini as well as the unconditional CRASH annotations from <https://dxr.mozilla.org/mozilla-central/search?q=path%3Atesting%2Fweb-platform%2Fmeta+CRASH&redirect=false> -- those crashes are because access to random web servers during tests kills the process.

Doing this would improve our test coverage, which is a good thing, right?  ;)

Comment 1

[Boris Zbarsky [:bzbarsky]]

These images are now hosted on get.webgl.org, so it's a matter of mapping that domain in our test infra and making the relevant path point to the right images...

Comment 2

[Kelsey Gilbert [:jgilbert]]

This was fixed.

Comment 3

[Boris Zbarsky [:bzbarsky]]

How is this fixed? As far as I can tell, still have tests in our tree that are truing to load stuff from https://get.webgl.org, which kills the test, so we are skipping them instead of running them.

Comment 4

[Kelsey Gilbert [:jgilbert]]

I thought we fixed this in a PR to the WebGL repo.

I'm not particularly worried about this, and I don't know the path forward to fixing this, but we can leave this open.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I thought we fixed this in a PR to the WebGL repo.

That fixed the tests pulling in a random image from somewhere on the web that wasn't even under the control of Khronos.

I'm not particularly worried about this

OK, if we're ok with the missing test coverage.

and I don't know the path forward to fixing this

Comment 0 generally describes the path, no?

Comment 6

[Kelsey Gilbert [:jgilbert]]

What we should probably do is add the two hostnames involved to our test HTTP server and map the relevant paths to something in-tree.

If you want to volunteer, sure, but this all sounds like whole days of work trying to track someone down to figure out how to do these things! I don't know how to move forward on those things.