Closed Bug 1333503 Opened 4 years ago Closed 4 years ago

Remove code relating to overfill

Categories

(Core :: Graphics: Layers, defect, P3)

53 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

See e.g. http://searchfox.org/mozilla-central/rev/02a56df6474a97cf84d94bbcfaa126979970905d/gfx/layers/client/ClientLayerManager.cpp#524 - there's a stack of code stretching from nsGlobalWindow to the compositor to do with compositor overfill ratios that looks unused. I think at least some of it was added for b2g back in bug 979949, so should be safe to remove.
Keywords: feature
Priority: -- → P3
Whiteboard: [gfx-noted]
I don't think this qualifies as a feature, it's just dead code removal.
Keywords: feature
Comment on attachment 8830337 [details]
Bug 1333503 - Remove some dead code relating to overfill calculation.

https://reviewboard.mozilla.org/r/107180/#review108350

Hoorah more b2g code removal! Thx.
Attachment #8830337 - Flags: review?(mchang) → review+
Comment on attachment 8830337 [details]
Bug 1333503 - Remove some dead code relating to overfill calculation.

Need a DOM peer to sign off on the webidl changes. :mrbkap, you reviewed the patch that added this in bug 979949, do you mind reviewing the deletion?
Attachment #8830337 - Flags: review?(mrbkap)
Comment on attachment 8830337 [details]
Bug 1333503 - Remove some dead code relating to overfill calculation.

https://reviewboard.mozilla.org/r/107180/#review108390

I'm always happy to review code removal.
Attachment #8830337 - Flags: review?(mrbkap) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/924e975566a5
Remove some dead code relating to overfill calculation. r=mchang,mrbkap
https://hg.mozilla.org/mozilla-central/rev/924e975566a5
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
No longer blocks: 1369194
You need to log in before you can comment on or make changes to this bug.