1333517 - "Report Site Issue" label breaks awkwardly on Linux and Windows

Status: RESOLVED FIXED

(Web Compatibility :: Tooling & Investigations, defect)

Description

[Dennis Schubert [:denschub]]

Attachment: Screenshot illustrating the issue

See that attached screenshot. I've noticed it sometimes does the same for other Add-ons, so maybe there is nothing we can do about it, but it's worth looking, I guess.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1333517 - Add soft-hyphens to Report Site Issue label to prevent hyphenation mid-word in English.

Review commit: https://reviewboard.mozilla.org/r/108306/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/108306/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8831765 [details]
Bug 1333517 - Add soft-hyphens to Report Site Issue label to prevent hyphenation mid-word in English.

https://reviewboard.mozilla.org/r/108306/#review109350

::: browser/extensions/webcompat-reporter/locales/en-US/webcompat.properties:7
(Diff revision 1)
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  # LOCALIZATION NOTE(wc-reporter.label): This string will be used in the
>  # Firefox menu panel below its button. Localized length should be considered.
> -wc-reporter.label=Report Site Issue
> +wc-reporter.label=Report \u00ad Site \u00ad Issue

Note that I didn't change the string ID here because the contents of the string isn't changing and this change is specific to the English locale.

Comment 3

[Mike Taylor [:miketaylr]]

Comment on attachment 8831765 [details]
Bug 1333517 - Add soft-hyphens to Report Site Issue label to prevent hyphenation mid-word in English.

https://reviewboard.mozilla.org/r/108306/#review109364

::: browser/extensions/webcompat-reporter/locales/en-US/webcompat.properties:7
(Diff revision 1)
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  # LOCALIZATION NOTE(wc-reporter.label): This string will be used in the
>  # Firefox menu panel below its button. Localized length should be considered.
> -wc-reporter.label=Report Site Issue
> +wc-reporter.label=Report \u00ad Site \u00ad Issue

Thanks for the patch!

I think we don't need "\o00ad" in multiple places, just once in the string, if I'm interpreting the following correctly:

https://dxr.mozilla.org/mozilla-central/source/browser/components/customizableui/content/panelUI.js#467

https://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties#86

Could we just stick it at the beginning of the label maybe adding to the note explaining it?

r+ with that tweak.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8831765 [details]
Bug 1333517 - Add soft-hyphens to Report Site Issue label to prevent hyphenation mid-word in English.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/108306/diff/1-2/

Comment 5

[Mike Taylor [:miketaylr]]

Comment on attachment 8831765 [details]
Bug 1333517 - Add soft-hyphens to Report Site Issue label to prevent hyphenation mid-word in English.

https://reviewboard.mozilla.org/r/108306/#review109364

LGTM!

> Thanks for the patch!
> 
> I think we don't need "\o00ad" in multiple places, just once in the string, if I'm interpreting the following correctly:
> 
> https://dxr.mozilla.org/mozilla-central/source/browser/components/customizableui/content/panelUI.js#467
> 
> https://dxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/customizableui/customizableWidgets.properties#86
> 
> Could we just stick it at the beginning of the label maybe adding to the note explaining it?
> 
> r+ with that tweak.

*\u00ad, that is.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38ae38323406
Add soft-hyphens to Report Site Issue label to prevent hyphenation mid-word in English. r=miketaylr

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/38ae38323406